Stop making unnecessary calls in Project Summary page #4729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Avoid making unnecessary calls for project with no submissions. Also don't show a "Not found" error for expected 404 response from API for the graph.
Notes
Things changed here:
SubmissionsCountGraph
component is making a call to counts API, a404
will be returned when there are no counts for given period. We were unnecessarily displaying error notification for thisFormSummaryProjectInfo
is making a call to submissions API to display information about latest submission. We were unnecessarily making call knowing there are no submissions