Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display submission counts only for users who have unrestricted access to view submissions #4739

Merged

Conversation

jnm
Copy link
Member

@jnm jnm commented Nov 28, 2023

Internal discussion: https://chat.kobotoolbox.org/#narrow/stream/6-Kobo-Support/topic/User's.20page.20not.20loading!/near/301064

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Those who have row-level "partial" permissions no longer have access to submission counts. This avoids 504 errors when the database cannot count the number of submissions that match the row-level filters fast enough.

have unrestricted access to view submissions; those who have row-level
"partial" permissions no longer have access to submission counts.

This avoids 504 errors when MongoDB cannot count the number of documents
matching the row-level queries fast enough.
@jnm jnm changed the base branch from main to release/2.023.37 November 28, 2023 04:55
@jnm jnm merged commit 67d8f20 into release/2.023.37 Nov 28, 2023
4 checks passed
@jnm jnm deleted the stop-returning-submission-counts-for-partial-permissions branch November 28, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant