Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable range selection of checkboxes #4742

Merged
merged 2 commits into from Dec 8, 2023
Merged

Conversation

RuthShryock
Copy link
Member

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Notes

Modified the bulkUpdateChange function to handle range selection by updating the state of selected checkboxes between the initial and final checkbox selection while the Shift key is pressed.

Related issues

Fixes #3995

Copy link

Copy link
Contributor

@LMNTL LMNTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works pretty well! The only change I would request is fairly small: it might be better if selecting the range only happened if you held the shift key down while selecting the start and end checkboxes (instead of just the end checkbox.)

…pressed down in order to use range selection
@LMNTL LMNTL merged commit a17e7e3 into beta Dec 8, 2023
4 checks passed
@LMNTL LMNTL deleted the enable-range-selection-checkboxes branch December 8, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants