Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form style bug in form builder #4753

Merged
merged 1 commit into from Dec 29, 2023
Merged

Fix form style bug in form builder #4753

merged 1 commit into from Dec 29, 2023

Conversation

RuthShryock
Copy link
Member

@RuthShryock RuthShryock commented Dec 6, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Allow form style setting to be retained when the user enters and leaves the form builder.

Notes

Changed the location of where we are accessing the settings__style variable when we open the form editor. The bug was that we were looking in the asset.settings_style which is undefined. The correct location is in the asset.content.settings.style.

Related issues

Fixes #3887

Copy link

Form builder bug

@RuthShryock RuthShryock changed the title Form style bug in form builder Fix form style bug in form builder Dec 12, 2023
@LMNTL LMNTL merged commit 630e737 into beta Dec 29, 2023
4 checks passed
@LMNTL LMNTL deleted the form-builder-bug branch December 29, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants