Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XLSX bulk library import, broken by #3765 #4779

Merged
merged 2 commits into from Dec 21, 2023

Conversation

jnm
Copy link
Member

@jnm jnm commented Dec 21, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Corrects the name 'writable' is not defined error when attempting to upload bulk library items with an XLSX (Excel 2007+) file

Notes

Internal discussion: https://chat.kobotoolbox.org/#narrow/stream/7-Kobo-UX.2FUI.2FProduct/topic/Library.20bulk.20imports/near/315222

@jnm jnm requested a review from noliveleger December 21, 2023 07:31
@jnm jnm assigned jnm and noliveleger and unassigned jnm Dec 21, 2023
Copy link

kpi/utils/rename_xls_sheet.py Show resolved Hide resolved
@noliveleger noliveleger merged commit 7b5c3e6 into release/2.023.48 Dec 21, 2023
4 checks passed
@noliveleger noliveleger deleted the fix-xlsx-bulk-library-import branch December 21, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants