New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update endpoints to handle Enterprise plans #4783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the unit test 😄
@@ -0,0 +1,139 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file merits broader review. Let's call it out of scope of this PR and we can change it later too. I'd love to discuss consistent generation of test data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub requires me to type here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is this the right branch to merge to? Do we still need to test it more on a staging site since changes were made?
Checklist
Description
Update endpoints to allow managing Enterprise plans. Update the service usage endpoint to get stats for all users in an organization if they have an Enterprise plan .
Notes
Mostly small changes -
CustomerPortalView
needed to be updated to handle the fact that Enterpise plans and storage add-ons aren't included in the default billing configuration. Also, the check in/organizations/{org id}/service_usage/
for all users in the current org has been uncommented, bugfixed, and made to only apply if the user has an Enterprise plan (Gold, Platinum.)Related issues
Front-end changes are included in kpi#4782