Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor redirect for plans page to not require a react-router version upgrade #4790

Merged
merged 4 commits into from Jan 3, 2024

Conversation

RuthShryock
Copy link
Member

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Original redirect pr required a react-router version upgrade which was throwing an AwaitRenderStatus reference error, see internal discussion: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/2.2E023.2E52.20release/near/318048

Notes

Reverting react-router version back to 6.14.2 and commenting out the authLoader function which was dependent on the upgrade. Moved PROJECTS_ROUTES to jsapp/js/projects/routes.tsx to prevent circular dependency errors and updated the requireAuth component to redirect appropriately based on the user's login status.

@LMNTL LMNTL merged commit b8355c0 into beta Jan 3, 2024
4 checks passed
@LMNTL LMNTL deleted the requireAuth-redirect-url branch January 3, 2024 18:32
LMNTL added a commit that referenced this pull request Jan 15, 2024
Refactor redirect for plans page to not require a react-router version upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants