Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide Social Apps that weren't already hidden during migration #4795

Merged
merged 1 commit into from Jan 17, 2024

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Jan 4, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Notes

The migration in question would create a SocialAppCustomData for any Social App it touched, hiding some providers on the login page that shouldn't have been. Before the allauth update, OIDC providers could be configured fully from environment variables, which would leave them hidden - now, only those providers are hidden. This should reduce the number of manual steps necessary to migrate providers from env vars to the database.

@LMNTL LMNTL requested a review from bufke January 4, 2024 19:40
@bufke bufke changed the base branch from release/2.023.48 to beta January 17, 2024 15:55
@bufke bufke merged commit caae391 into beta Jan 17, 2024
4 checks passed
@JacquelineMorrissette JacquelineMorrissette deleted the dont-hide-social-providers branch January 29, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants