Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NewFeatureDialog to only show once on form landing page #4810

Merged
merged 3 commits into from Jan 19, 2024

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Jan 18, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Makes the NewFeatureDialog for Anonymous Submissions only show once in the form landing page, instead of appearing next to the Enketo links and in the sharing modal.

Notes

  • Makes the NewFeatureDialog component wrap its children, so that it doesn't need to be rendered inside of the component it highlights.
  • Adds a new prop, featureKey, to NewFeatureDialog. Use it to differentiate between dialogs for different features.

@LMNTL LMNTL requested a review from duvld January 18, 2024 21:58
@LMNTL LMNTL changed the title refactor NewFeatureDialog to wrap component, only show once on form landing Refactor NewFeatureDialog to only show once on form landing page Jan 18, 2024
@duvld duvld merged commit 6b0a0a1 into new-feature-dialog Jan 19, 2024
4 checks passed
@duvld duvld deleted the new-feature-dialog-hide-under-modal branch January 19, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants