Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle submission XML with namespace or encoding declaration #4832

Merged
merged 5 commits into from Feb 12, 2024

Conversation

jnm
Copy link
Member

@jnm jnm commented Feb 5, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Previously, submissions with namespaces or encoding declarations in their XML could not be bulk edited or cloned.

Notes

Makes some progress toward standardized XML handing with defusedxml. In the future, all XML work should be done in kpi.utils.xml.

Related issues

Fixes #4283

contains a namespace or encoding declaration (tests currently fail)
declaration, which previously could not be bulk edited or cloned. Makes
some progress toward standardized XML handing with defusedxml.

Fixes #4283
kpi/utils/xml.py Outdated Show resolved Hide resolved
@noliveleger noliveleger merged commit 897157f into release/2.024.05 Feb 12, 2024
4 checks passed
@noliveleger noliveleger deleted the 4283-bulk-edit-xml-with-namespace branch February 12, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants