Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent autocomplete on mfa entry fields #4895

Merged
merged 2 commits into from Apr 9, 2024
Merged

Prevent autocomplete on mfa entry fields #4895

merged 2 commits into from Apr 9, 2024

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Apr 4, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Prevent MFA token input fields from being autocompleted.

Notes

Adds an optional disableAutocomplete prop to <TextBox>.

Copy link

@@ -256,14 +264,13 @@ const MFAModals = class MFAModals extends React.Component<
errors={this.state.errorText}
value={this.state.inputString}
onChange={this.onInputChange.bind(this)}
disableAutocomplete={true}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think linter will complain that disableAutocomplete is enough (i.e. without ={true})

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I always forget about that 😅

jsapp/js/components/bigModal/mfaModals.tsx Outdated Show resolved Hide resolved
jsapp/js/components/bigModal/mfaModals.tsx Outdated Show resolved Hide resolved
@LMNTL LMNTL merged commit fd59065 into beta Apr 9, 2024
4 checks passed
@LMNTL LMNTL deleted the mfa-autocomplete branch April 9, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants