Make image attachments resizing work again #4952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
force-pushed
the
fix-attachment-resize
branch
from
7609ec4
to
5ee0b9e
Compare
noliveleger
changed the base branch from
refactor-kobo-docker-env-vars
to
fix-migrations-new-install
Drop CSV import support from API v1
jnm
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API
v2exposeslarge,medium,smallversions of image attachments.Notes
All the links were pointing to the same file without any resizing while using API
v2since the code was sitting in Kobocat repo. Having the code available in the same repo now let us call the code that resize the images on the fly,