Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescriptize Library files #4961

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Jun 3, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Notes

Typescriptized 7 components from Library directory. This time I tried just migrating to TS without any additional fixes/improvements.

Related issues

It's a cleanup PR done while debugging TASK-788

Copy link

Library pagination

@magicznyleszek magicznyleszek changed the base branch from main to beta June 3, 2024 12:09
@magicznyleszek magicznyleszek marked this pull request as ready for review June 3, 2024 12:11
@magicznyleszek magicznyleszek force-pushed the task-788-typescriptize-library-files branch from bc9df2e to 4f3ea76 Compare June 3, 2024 16:24
@magicznyleszek magicznyleszek changed the title [TASK-788] Typescriptize Library files Typescriptize Library files Jun 3, 2024
@magicznyleszek magicznyleszek mentioned this pull request Jun 3, 2024
7 tasks
@p2edwards p2edwards merged commit 5abfdf4 into beta Jun 20, 2024
5 checks passed
@p2edwards p2edwards deleted the task-788-typescriptize-library-files branch June 20, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants