Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK-806] Duplicating submissions doesn’t copy extra submission details #5003

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

Guitlle
Copy link

@Guitlle Guitlle commented Jul 9, 2024

Description

This PR solves the issue when data is duplicated and the submission extras are not copied to the new instance.

Notes

The code on the kobocat deployment class was changed to duplicate the submission extras after the submission is duplicated.

Related issues

Task 806 on Notion.

@Guitlle Guitlle requested a review from noliveleger July 9, 2024 19:11
Copy link

@noliveleger noliveleger marked this pull request as ready for review July 10, 2024 19:05
kpi/deployment_backends/base_backend.py Outdated Show resolved Hide resolved
kpi/tests/api/v2/test_api_submissions.py Outdated Show resolved Hide resolved
kpi/views/v2/data.py Outdated Show resolved Hide resolved
kpi/views/v2/data.py Outdated Show resolved Hide resolved
Comment on lines +231 to +235
@property
@abc.abstractmethod
def form_uuid(self):
pass

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@noliveleger noliveleger merged commit 4b1979c into beta Jul 10, 2024
4 of 5 checks passed
@noliveleger noliveleger deleted the TASK-806-fix-duplication-error branch July 10, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants