Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Customize Navigation Sidebar #388

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

ricoberger
Copy link
Member

It is now possible to customize the navigation sidebar, by adding custom
navigation groups and items. Each navigation item can contain a list of
child items or a reference to a dashboard. The dashboard reference must
contain the satellite, cluster, namespace and name of the dashboard. It
can also contain a list of placeholders, which are passed to the
dashboard.

Instead of the proposed solution in #384 we did not use the Flyout
component, because the component was not working properly on mobile
devices. We decided to use expandable navigation items.

Closes #384.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #388 (c730824) into main (347644c) will increase coverage by 0.05%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   45.26%   45.32%   +0.05%     
==========================================
  Files         132      133       +1     
  Lines       10314    10326      +12     
==========================================
+ Hits         4669     4680      +11     
- Misses       5567     5568       +1     
  Partials       78       78              
Impacted Files Coverage Δ
pkg/hub/hub.go 0.00% <0.00%> (ø)
pkg/hub/api/navigation/navigation.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347644c...c730824. Read the comment docs.

It is now possible to customize the navigation sidebar, by adding custom
navigation groups and items. Each navigation item can contain a list of
child items or a reference to a dashboard. The dashboard reference must
contain the satellite, cluster, namespace and name of the dashboard. It
can also contain a list of placeholders, which are passed to the
dashboard.

Instead of the proposed solution in #384 we did not use the Flyout
component, because the component was not working properly on mobile
devices. We decided to use expandable navigation items.

Closes #384.
@ricoberger ricoberger force-pushed the app-customize-navigation-sidebar branch from 639e7e9 to c730824 Compare July 9, 2022 21:18
@ricoberger ricoberger merged commit 1967c64 into main Jul 9, 2022
@ricoberger ricoberger deleted the app-customize-navigation-sidebar branch July 9, 2022 21:32
@ricoberger ricoberger added the changelog: added A new feature was added label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: added A new feature was added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[app] Customize Navigation Bar
2 participants