Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Fix terminal for Kubernetes Pods #391

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

ricoberger
Copy link
Member

This commit fixes two smaller problems with the built-in terminal for
Kubernetes Pods:

  • When a opened a terminal and then selected another container or shell
    to open a new terminal the commands where send twice to the terminal.
  • When a user reached the end of a line the command overflows to the
    start of the line instead of a new line.

This commit fixes two smaller problems with the built-in terminal for
Kubernetes Pods:

- When a opened a terminal and then selected another container or shell
  to open a new terminal the commands where send twice to the terminal.
- When a user reached the end of a line the command overflows to the
  start of the line instead of a new line.
@codecov-commenter
Copy link

Codecov Report

Merging #391 (0401194) into main (17c699b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   45.20%   45.20%           
=======================================
  Files         134      134           
  Lines       10377    10377           
=======================================
  Hits         4691     4691           
  Misses       5608     5608           
  Partials       78       78           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c699b...0401194. Read the comment docs.

@ricoberger ricoberger merged commit 184289e into main Jul 11, 2022
@ricoberger ricoberger deleted the app-fix-terminal-for-kubernetes-pods branch July 11, 2022 12:12
@ricoberger ricoberger added the changelog: changed Something was changed or updated label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: changed Something was changed or updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants