[app] Custom User and Team Notifications #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricoberger
force-pushed
the
app-allow-users-and-teams-to-customize-notifications
branch
from
a6e4160
to
3248be8
Compare
It is now possible to customize the notification settings per user and team. For that a new "notifications" property was added to both CRDs, which can be used to define custom notification groups. If a user or teams has not defined any notifications the global notification groups are used. We also adjusted the documentation and added a "Notification Options" section for each plugin. Besides that we also fixed a bug in the applications and teams API, where the "Teams" field was used to check the users permissions instead of the "Permissions.Teams" field from the user context. This was noticed, because we added the list of teams from the corresponding header also when authentication is disabled.
ricoberger
force-pushed
the
app-allow-users-and-teams-to-customize-notifications
branch
from
3248be8
to
5520a50
Compare
Codecov Report
@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 45.21% 45.43% +0.21%
==========================================
Files 134 134
Lines 10379 10435 +56
==========================================
+ Hits 4693 4741 +48
- Misses 5608 5614 +6
- Partials 78 80 +2
Continue to review full report at Codecov.
|
ricoberger
deleted the
app-allow-users-and-teams-to-customize-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to customize the notification settings per user and
team. For that a new "notifications" property was added to both CRDs,
which can be used to define custom notification groups. If a user or
teams has not defined any notifications the global notification groups
are used.
We also adjusted the documentation and added a "Notification Options"
section for each plugin.
Closes #385