Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Add missing sort keys to MongoDB queries #403

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

ricoberger
Copy link
Member

We missed the sort key for multiple queries during the implementation of
the MongoDB driver. These keys are now added so that the order is the
exact same as it is for the Bolt driver.

We also added a "make vet" command to the continuous integration
pipeline to check for suspicious constructs like the following which was
introduced by the MongoDB driver:

go.mongodb.org/mongo-driver/bson/primitive.E composite literal uses unkeyed fields

This is now fixed by changing all occurences of "bson.D{{"key", "value"}}"
to "bson.D{{Key: "key", Value: "value"}}".

We missed the sort key for multiple queries during the implementation of
the MongoDB driver. These keys are now added so that the order is the
exact same as it is for the Bolt driver.

We also added a "make vet" command to the continuous integration
pipeline to check for suspicious constructs like the following which was
introduced by the MongoDB driver:

go.mongodb.org/mongo-driver/bson/primitive.E composite literal uses unkeyed fields

This is now fixed by changing all occurences of "bson.D{{"key", "value"}}"
to "bson.D{{Key: "key", Value: "value"}}".
@ricoberger ricoberger merged commit 7b653d2 into main Jul 26, 2022
@ricoberger ricoberger deleted the app-add-missing-sort-keys branch July 26, 2022 18:14
@ricoberger ricoberger added the changelog: fixed Something which wasn't working is fixed label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fixed Something which wasn't working is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant