Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Replace plouc/nivo with @patternfly/react-charts #423

Merged

Conversation

ricoberger
Copy link
Member

@ricoberger ricoberger commented Sep 1, 2022

We are now using @patternfly/react-charts instead of plouc/nivo for our
charts.

@ricoberger ricoberger force-pushed the app-replace-nivo-charts-with-patternfly-react-charts branch from a39418c to 59fc563 Compare September 1, 2022 07:55
We are now using @patternfly/react-charts instead of plouc/nivo for our
charts.
@ricoberger ricoberger force-pushed the app-replace-nivo-charts-with-patternfly-react-charts branch from 59fc563 to 40c0376 Compare September 1, 2022 08:28
@ricoberger ricoberger changed the title [app] Replace @nivo with @patternfly/react-charts [app] Replace plouc/nivo with @patternfly/react-charts Sep 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #423 (40c0376) into main (71b6939) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   45.61%   45.61%   -0.01%     
==========================================
  Files         139      139              
  Lines       11892    11893       +1     
==========================================
  Hits         5425     5425              
- Misses       6328     6329       +1     
  Partials      139      139              
Impacted Files Coverage Δ
plugins/plugin-klogs/pkg/instance/aggregation.go 7.42% <0.00%> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ricoberger ricoberger merged commit 32d4cc8 into main Sep 1, 2022
@ricoberger ricoberger deleted the app-replace-nivo-charts-with-patternfly-react-charts branch September 1, 2022 08:55
@ricoberger ricoberger added the changelog: changed Something was changed or updated label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: changed Something was changed or updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants