Fix the test so it works with 'colcon test' #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This should make it a bit more suitable for "standalone" testing. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
It seems that 'colcon test' has a different execution path than 'ros2 test', so we can't rely on the launch_ros_node being available. Make sure to create our own node, and then use that for the subscriptions. This also necessitated a change in how the checking loop was done. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
@stonier Friendly ping here, any chance to review and merge this? |
stonier
requested changes
Mar 22, 2020
We actually don't need to do anything exotic with matplotlib as long as we aren't trying to display to the screen. So restore the useful functionality. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Needed on the buildfarm. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
stonier
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit has the explanation, but essentially we had to change the idea of how we do the test a bit. I also did a bunch of cleanup of the test. In my testing, this now works for both
ros2 testandcolcon test.This should fix #10