Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port velocity smoother to ROS 2. #1

Merged
merged 6 commits into from
Jan 20, 2020
Merged

Port velocity smoother to ROS 2. #1

merged 6 commits into from
Jan 20, 2020

Conversation

clalancette
Copy link
Collaborator

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This is a port of the velocity smoother from ROS 1 to ROS 2. This supersedes yujinrobot/kobuki#405.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
launch/velocity_smoother-launch.py Outdated Show resolved Hide resolved
src/velocity_smoother.cpp Show resolved Hide resolved
launch/velocity_smoother-launch.py Outdated Show resolved Hide resolved
config/velocity_smoother_params.yaml Show resolved Hide resolved
package.xml Show resolved Hide resolved
include/velocity_smoother/velocity_smoother.hpp Outdated Show resolved Hide resolved
src/velocity_smoother_node.cpp Show resolved Hide resolved
test/test_translational_input.py Show resolved Hide resolved
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
launch/velocity_smoother-launch.py Outdated Show resolved Hide resolved
config/velocity_smoother_params.yaml Show resolved Hide resolved
src/velocity_smoother_node.cpp Show resolved Hide resolved
test/test_translational_input.py Show resolved Hide resolved
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Copy link
Contributor

@stonier stonier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About to launch into a rebuild, see if I can reproduce that compile time error.

@stonier stonier mentioned this pull request Jan 20, 2020
8 tasks
@stonier
Copy link
Contributor

stonier commented Jan 20, 2020

LGTM, I created a meta-issue tracking remaining work in #2.

@stonier
Copy link
Contributor

stonier commented Jan 20, 2020

Merging, so I can move on with releasing and other remaining work in #2.

@stonier stonier merged commit f111233 into master Jan 20, 2020
@stonier stonier deleted the ros2-port branch January 20, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants