Skip to content

Commit

Permalink
Merge pull request #2848 from kodadot/main
Browse files Browse the repository at this point in the history
Too Soon Junior
  • Loading branch information
yangwao committed Apr 13, 2022
2 parents 665d61a + f92d2e9 commit 8ec35b2
Show file tree
Hide file tree
Showing 119 changed files with 2,082 additions and 780 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @kodadot/code-review-guild
44 changes: 12 additions & 32 deletions .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,37 +4,12 @@
"automerge": true,
"automergeType": "pr-comment",
"automergeComment": "lgtm",
"rangeStrategy": "bump",
"extends": [
"github>whitesource/merge-confidence:beta",
"config:base",
":dependencyDashboard"
],
"extends": ["config:base", ":dependencyDashboard"],
"prHourlyLimit": 5,
"schedule": [
"after 10pm every weekday",
"before 6am every weekday",
"every weekend"
],
"enabledManagers": ["regex"],
"regexManagers": [
{
"fileMatch": ["(^|/)Dockerfile%"],
"matchStrings": ["ENV NODE_VERSION (?<currentValue>.*?)\n"],
"depNameTemplate": "node",
"datasourceTemplate": "node"
}
],
"enabledManagers": ["npm"],
"rangeStrategy": "bump",
"separateMinorPatch": true,
"packageRules": [
{
"matchUpdateTypes": ["major"],
"enabled": false
},
{
"updateTypes": ["minor", "patch", "pin"],
"groupName": "Bumped minor version of packages",
"prHeader": "Bumped minor version of packages, check if builds are still passing, please 🥺"
},
{
"matchSourceUrlPrefixes": [
"https://github.com/polkadot-js/",
Expand All @@ -47,10 +22,15 @@
"groupName": "merge with hazmat suit extra",
"enabled": false
},
{
"groupName": "Bumped minor version of packages",
"prHeader": "Bumped minor version of packages, check if builds are still passing, please 🥺",
"matchUpdateTypes": ["minor", "patch"],
"matchDepTypes": ["dependencies", "devDependencies"]
},
{
"matchUpdateTypes": ["major"],
"enabled": true,
"matchManagers": ["regex"]
"enabled": false
}
]
}
}
81 changes: 30 additions & 51 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
# Contributing to KodaDot: NFT gallery

KodaDot NFT gallery has a plan to be community-owned.
We are welcoming community contributions from you.
KodaDot NFT gallery **has a plan to be builders-owned and become ultimate public good**

We are welcoming community contributions from you by rewarding your contributions.
Take a sneak peek on [good first issues](https://github.com/kodadot/nft-gallery/contribute), comment, and make PR.
If everything goes well, chances that you will be **rewarded are high**. We might give retro-active bounties where the bounty label wasn't present if we like your commit.
If everything goes well, chances that you will be **rewarded are high**.

We might give retro-active reward, where the bounty label wasn't present, **if we like your contribution.**

**For better coordination, please join our [Development channel (#coordination) on Discord](https://discord.gg/4CeHXamhqB)**

Expand All @@ -15,12 +18,17 @@ Before you being:
- Make sure that you use [**pnpm**](https://pnpm.io/installation) as the package manager.
- Please have a read the [code of conduct](CODE_OF_CONDUCT.md)
- [Learn how to set up your environment for the first time](FIRST_TIME.md)
- Get familiar with our [coding conventions & recommendations](STYLE_GUIDE.md)

### Which issue should you pick?

We are working primarily on two metrics. Issues have priorities by labels [p1-p5](https://github.com/kodadot/nft-gallery/labels), **p1 means urgent**, **p5 in research mode**. Then we have bounties for issues in the range of **$ - $$$$$**.
We are working primarily on two metrics.
Issues have
- priorities by labels [p1-p5](https://github.com/kodadot/nft-gallery/labels), **p1 means urgent**, **p5 in research mode**.
- bounties labels for issues in the range of **$ - $$$$$**. Check [Rewards](REWARDS.md)

If you are going to contribute, please select issues with the highest urgency (p1, p2) first. It makes a huge difference for users to fix high-priority issues. If there is no such issue, our **best advice is to choose issues reflecting your skillset and experience** if you are interested to be part of internal team and having continuous payroll from us.
If you are going to contribute, please select issues with the highest urgency (p1, p2) first. It makes a **significant difference for users to fix high-priority issues**.
If there is no such issue, our **best advice is to choose issues reflecting your skillset and experience**.

### Open a pull request

Expand All @@ -38,49 +46,11 @@ Congratulations! The whole Metaprime & KodaDot community thanks you. ✨

## Rewards

To scale our development and operations, we prefer paid trials to know developers better and fit the team. More your PRs gets merged to `main` branch, **more-likely you'll be part of the inner team.**
On-demand or part-time contributions are welcome, and **we will reward them in $KSM**

KodaDot has started on [Kusama.network](https://kusama.network), and we prefer to pay out for your work in $KSM, which is the native cryptocurrency of Kusama network, [Polkadot's Canary network](https://polkadot.network) with bearing value.

### Creating your KSM address

To create your KSM address in safely and long-term manner, we recommend you to get [Polkadot.js wallet browser extension](https://guide.kusama.network/docs/learn-account-generation/#polkadotjs-browser-plugin). You can [learn more about creating KSM address process at the official Kusama Guide](https://guide.kusama.network/docs/learn-account-generation/)

### Sharing your address to receive the reward

After creating an account, you can visit [KodaDot Transfer](https://kodadot.xyz/transfer) to make a payment link. Entering an amount like 100 USD and clicking the button _Copy Payout address_ will copy the link to your clipboard, and you can share it with us, like whenever you are filling up a bug report or submitting pull-request

### Switching account/network

While you are on your _[accounts](https://polkadot.js.org/apps/#/accounts)_ dashboard, check the top-left corner to confirm and ensure your current network. Click the avatar to see options to select from and switch as desired.

> To switch to Kusuma Network, search and select **KUSAMA** under _KUSAMA & PARACHAINS_ and `switch` by selecting the **switch** option at the top-most area of the opened side nav.
### Checking your KSM balance

Check `balances` under your _[accounts](https://polkadot.js.org/apps/#/accounts)_ dashboard to see that. Because we use KSM, you need to ensure you are on the _Kusuma network_. Check the top-left corner to confirm and ensure your `balance` is in **KSM**. If not, kindly _switch network_ by clicking the avatar on your top-left corner, and switch to **_Kusuma_**. Your **balances** will now be in **KSM**.

### Bounty levels

Our typical payout structure for bounties is per label on the issue. Here is the table for an overview

| $ | $$ | $$$ | $$$$ | $$$$$ |
| :----------------------------------------------------------: | :---------------------------------------------------: | :---------------------------------------------------------------: | :-------------------------------------------------------------: | :------------------------------------------------------------------------------------: |
| 50-100 | 150-300 | 450-600 | 700 - 1000 | 1000+ |
| Beginner, few lines, <br /> lot of comments/assistance on PR | Required brain use, <br /> smart solution, autonomous | Complex, delivered new shiny stuff, <br /> did not break anything | Dedicated, new feature, rework older stuff, quick delivery time | You seems reliable, responsible, we can trust you, and you have alignment with project |

You can [check recent labels](https://github.com/kodadot/nft-gallery/labels)
Continue to [REWARDS.md](REWARDS.md)

## Hiring process

After you've **completed a few PRs, which we've merged to the upstream `main` branch**, you will be eligible to join our closer team.
We are happy to give you **one or two long-term tasks** to see how you can tackle more complicated and complex issues.

The reasoning behind this is to see if we **click together as a team in the long run.**
We are curious _about your character traits, acting, and helping others_ if they have an issue with their PR.

We can guarantee you a payroll from this phase, which will be discussed based on your location, skillset, previous experience, and quality of delivered code.
Continue to [HIRING.md](HIRING.md)

# Learn more about contributing:

Expand Down Expand Up @@ -140,14 +110,14 @@ Thank you for creating them.

Labels can help you find a perfect issue for your skills.

The [help wanted](https://github.com/kodadot/nft-gallery/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) label is for problems or updates that anyone in the community can start working on.
The [good first issue](https://github.com/kodadot/nft-gallery/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22) label is for problems or updates we think are ideal for beginners.
- The [help wanted](https://github.com/kodadot/nft-gallery/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) label is for problems or updates that anyone in the community can start working on.
- The [good first issue](https://github.com/kodadot/nft-gallery/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22) label is for problems or updates we think are ideal for beginners.

## Pull Requests

Pull requests are a great way to get your ideas into this repository.

When deciding if I merge in a pull request, I look at the following things:
When deciding if we merge in a pull request, we look at the following things:

### Does it state intent

Expand All @@ -172,7 +142,9 @@ Doesn't tell me anything about why you're doing that

### Reviewing

We (usually the core team, sometimes KodaDot engineers or support too!) review every PR. The purpose of reviews is to create the best content for people who use KodaDot.
We (usually the core team, sometimes KodaDot engineers or support too!) review PR where they been requested to do so.

The purpose of reviews is to create the best content for people who use KodaDot and raise code-quality at each pull-request.

💛 Reviews are always respectful, acknowledging that everyone did the best possible job with the knowledge they had at the time.

Expand Down Expand Up @@ -209,7 +181,8 @@ When you open a pull request, you must fill out the "Ready for review" template

### Code quality

We follow what we have in `.eslintrc.js`, and you can see warnings and errors by running `pnpm lint`. With `pnpm lint --fix`, you will get auto fixed code.
- We follow what we have in `.eslintrc.js`, and you can see warnings and errors by running `pnpm lint`. With `pnpm lint --fix`, you will get auto fixed code.
- We've formed [STYLE_GUIDE.md](STYLE_GUIDE.md) to help you answer formatting questions.

### Don't have access to push to the repository

Expand All @@ -225,7 +198,7 @@ The aim of this repository is:

### Better comfort

For crafting much better culture and DEVUX, we reccomend some extension to browse issue faster
For crafting much better culture and Developer Experience, we reccomend some extension to browse issues faster

- [Refined Github](https://chrome.google.com/webstore/detail/refined-github/hlepfoohegkhhmjieoechaddaejaokhf)
- [Github HoverCard](https://chrome.google.com/webstore/detail/github-hovercard/mmoahbbnojgkclgceahhakhnccimnplk)
Expand All @@ -236,6 +209,12 @@ For crafting much better culture and DEVUX, we reccomend some extension to brows

This repository has a [code of conduct](CODE_OF_CONDUCT.md). This repository has a code of conduct, and I will remove things that do not respect it.

## Follow us

- [Twitter @KodaDot](https://twitter.com/kodadot)
- [Medium Kodadot](https://medium.com/kodadot)
- [Documentation](https://docs.kodadot.xyz)

### Related

Check best [contributing.md](https://github.com/github/docs/blob/main/CONTRIBUTING.md)
46 changes: 46 additions & 0 deletions HIRING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
### KodaDot is always hiring
We always looking for **smart and talented frontend developers**. Either you want to start with us as **your side-hustle or looking for full-time dedication**, our issues are open to tackle and get rewarded instantly in crypto once your solution is merged to upstream branch.

### We can offer you full spectrum frontend jobs at KodaDot
- full-time
- part-time
- internship
- freelance
- temporary

### Qualification for full-time & part-time & paid internship
To qualify for part-time or full-time, we are looking on your
- past track record on your Github profile, i.e. your open-source contributions matters most.
- co-operation & co-ordination -- how well your help each other in code review process, what's your participation in our issues/discussions/discord
- how well & quickly you react for particular issues and change requests after review was made
- what's your overall skillset & experience
- if you are fast learner
- quality of delivered code
- You should have **10-20** merged pull-requests to our upstream branch

### How to apply?

#### Paid interiview
With each closed issue we will pay for your time.
Hence we value your time, most of your **completed a pull-requests, i.e. 10-20** are getting paid.

### Which issue to pick?

You can [check recent issues by labels p1 or p2](https://github.com/kodadot/nft-gallery/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Ap1%2Cp2)

#### Next stage
Once you've crossed **10-20 merged pull requests**, which were successfully merged to the upstream `main` branch, you will be **eligible to join our closer team**.

Feel free to reach out `yangwao` on our Discord.
We are happy to give you **one or two long-term tasks** to see how you can tackle more complicated and complex issues.

#### Reasoning
The reasoning behind this is to see **if we click together as a team in the long run.**
We are curious about your character traits, acting, and helping others if they have an issue with their PR, which is important for long-term team growth.

#### Payroll
We can **guarantee you a payroll from this phase**, which will be discussed based on your location, skillset, previous experience, quality of delivered code and time availibility. We would like match market prices. Landing job at KodaDot could result getting payroll on range between **60k-160k$ annual compensation.**

#### Questions?

Head's up to our [Discord - channel #jobs](https://discord.gg/4CeHXamhqB)
Loading

0 comments on commit 8ec35b2

Please sign in to comment.