Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent button components #10018

Closed
exezbcz opened this issue Apr 7, 2024 · 4 comments · Fixed by #10066
Closed

Consistent button components #10018

exezbcz opened this issue Apr 7, 2024 · 4 comments · Fixed by #10066
Labels
🧹 - clean-up A-maintenance p3 non-core, affecting less than 40% visual change not affecting ux of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Apr 7, 2024

there were some efforts to make it similar to the figma page:

can we please make it globally consistent? Here are button that i will use in 95% of cases
https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=5311-18771&mode=design&t=aJlAZ4RTAQ0h30Mw-11

image

#8222 (comment)
-> components done, in the figma

there are also some changes
- regular button now has a height of 40px instead of 36. Will work better as a touchpoint

The large button is on the other hand smaller - 52px instead of 56

both light and dark mode

@exezbcz exezbcz added p3 non-core, affecting less than 40% 🧹 - clean-up visual change not affecting ux of app A-maintenance labels Apr 7, 2024
@prachi00
Copy link
Member

prachi00 commented Apr 8, 2024

👋🏻

@kodabot
Copy link
Collaborator

kodabot commented Apr 8, 2024

ASSIGNED - @prachi00 🔒 LOCKED -> Wednesday, April 10th 2024, 06:28:25 UTC -> 36 hours

@kodabot
Copy link
Collaborator

kodabot commented Apr 10, 2024

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@exezbcz
Copy link
Member Author

exezbcz commented Apr 12, 2024

working on it? @prachi00

prachi00 added a commit to prachi00/nft-gallery that referenced this issue Apr 12, 2024
@prachi00 prachi00 mentioned this issue Apr 12, 2024
5 tasks
@prachi00 prachi00 mentioned this issue Jun 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 - clean-up A-maintenance p3 non-core, affecting less than 40% visual change not affecting ux of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants