-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button css changes #10066
Button css changes #10066
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
and other buttons? |
which ones? |
@exezbcz which ones? I changed the height, added focus, active states |
|
@exezbcz done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been standing around way too long for a small change
@hassnian the story book is probably outdated and quite unused
I've looked around through the app, all buttons look ok, just a bit taller
however, the NeoButtonVariants
are outdated and don't match current figma variants, let's change that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we merge this now? |
Code Climate has analyzed commit 70f8273 and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
@prury can we test and merge this one? thanks |
indeed |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary