Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection preview for Telegram #118

Closed
yangwao opened this issue Feb 23, 2021 · 15 comments
Closed

Collection preview for Telegram #118

yangwao opened this issue Feb 23, 2021 · 15 comments
Labels
$ ~<50usd good first issue as new commer, something you could start with p4 affecting less than 10% of app

Comments

@yangwao
Copy link
Member

yangwao commented Feb 23, 2021

we need to figure out collection view and on the telegram have this kind of previews

https://twitter.com/roni_hobby/status/1363831918337294336

image

@yangwao yangwao mentioned this issue Mar 4, 2021
@yangwao yangwao added the good first issue as new commer, something you could start with label Mar 7, 2021
@yangwao yangwao added the $ ~<50usd label Mar 24, 2021
@miguel-quezada63
Copy link
Contributor

Do you have any resources available on Telegram collection previews? I am unable to find any information on this feature.

@yangwao
Copy link
Member Author

yangwao commented Apr 23, 2021

Yeah, me either. I guess it's some telegram stuff, if you won't find anything on it, it's low-prio, but it would be good for some good experience. Wondering for example how discord process OG tags.

@yangwao
Copy link
Member Author

yangwao commented Jun 3, 2021

@yangwao yangwao added the p4 affecting less than 10% of app label Jul 1, 2021
@roiLeo
Copy link
Contributor

roiLeo commented Jul 8, 2021

Telegram Instant view documentation related.

@vikiival
Copy link
Member

Screenshot 2021-08-23 at 19 10 16

Screenshot 2021-08-23 at 19 09 07

🤔

@niklasp
Copy link
Contributor

niklasp commented Jun 10, 2022

👋

@kodabot
Copy link
Collaborator

kodabot commented Jun 10, 2022

ASSIGNED - @niklasp 🔒 LOCKED -> Saturday, June 11th 2022, 12:34:29 UTC -> 36 hours

@niklasp
Copy link
Contributor

niklasp commented Jun 10, 2022

I researched without a result, then i looked at the corresponding telegram code https://github.com/telegramdesktop/tdesktop/blob/1ebd9562a2c5bd797f06c961e6282307a2e8602d/Telegram/SourceFiles/data/data_web_page.cpp#L131-L139. I would suggest closing this issue, as i did not find any working example. Also the example above does only create one photo in the link preview. Maybe it was working some time ago but seems disabled.

@kodabot
Copy link
Collaborator

kodabot commented Jun 11, 2022

ASSIGNMENT EXPIRED - @niklasp has been unassigned.

@niklasp
Copy link
Contributor

niklasp commented Jun 11, 2022

@vikiival @roiLeo can you verify and close this?

@vikiival
Copy link
Member

It does not work :)

IMG_2750

@niklasp
Copy link
Contributor

niklasp commented Jun 12, 2022

Oh so I understand that now it is about a Single image for a collection. Was referring to multiple which is not possible. But will reassign myself and work on this soon

@vikiival
Copy link
Member

But will reassign myself and work on this soon

It would be better to find something with p1 or p2 label.

@niklasp
Copy link
Contributor

niklasp commented Jun 13, 2022

I know, I am just getting started and slowly getting to know the code, will work on more, my first PR is still pending

@roiLeo
Copy link
Contributor

roiLeo commented Nov 23, 2023

related with #7999

@roiLeo roiLeo closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd good first issue as new commer, something you could start with p4 affecting less than 10% of app
Projects
None yet
Development

No branches or pull requests

6 participants