Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collection): improve SEO #560

Merged
merged 4 commits into from
Jul 9, 2021
Merged

feat(collection): improve SEO #560

merged 4 commits into from
Jul 9, 2021

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 8, 2021 •
edited
Loading

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

PR type

  • Bugfix
  • Feature
  • Refactoring

Changes

  • fix semantic collection by adding h1
  • fix galleryCard image alternative text
  • add meta og:url
  • add meta twitter:card
  • add subscan svg alternative text

@roiLeo roiLeo changed the title feat(collection): improve SEO DRAFT: feat(collection): improve SEO Jul 8, 2021
@roiLeo roiLeo marked this pull request as draft July 8, 2021 12:58
@roiLeo roiLeo marked this pull request as ready for review July 8, 2021 14:30
@yangwao
Copy link
Member

yangwao commented Jul 8, 2021 •
edited
Loading

Do you refer to this one #118 ?

Looks the same to me here
image

@roiLeo roiLeo changed the title DRAFT: feat(collection): improve SEO feat(collection): improve SEO Jul 8, 2021
@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 8, 2021

This is not #118 related, I've added a comment in issue for telegram documentation.
This PR fix semantic issue (h1), add open graph basic Metadata (og:url) and preview twitter card for large images.

@yangwao yangwao merged commit 3700189 into kodadot:main Jul 9, 2021
@roiLeo roiLeo deleted the feature/collection/seo branch August 23, 2021 17:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roiLeo @yangwao @vikiival