Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing last NFT mint from user profile in OG:image #306

Merged
merged 9 commits into from
May 5, 2021

Conversation

miguel-quezada63
Copy link
Contributor

@miguel-quezada63 miguel-quezada63 commented Apr 22, 2021

From issue #287. og:image was missing from link cards shown on social media platforms. Added og:image meta property in which displays the user's latest NFT that is an image.

Added og:title, og:image, og:video, twitter:title, twitter:card metadata
properties in order to add
image of the last mint from a user and their username on open
graph display cards.

Also added @edgeware/node-types
due to having issues with yarn serve
complaining about the package not existing.
Added og:title, og:image, og:video, twitter:title, twitter:card metadata
properties in order to add
image of the last mint from a user and their username on open
graph display cards.

Also added @edgeware/node-types
due to having issues with yarn serve
complaining about the package not existing.
Added og:title, og:image, og:video, twitter:title, twitter:card metadata
properties in order to add
image of the last mint from a user and their username on open
graph display cards.
c61e2b1:

Image loading using og:image was not functioning correctly as some profiles
may have videos as their lastest mint. To resolve this, the latest
NFT is used for og:image.
Image was not displaying with profiles in which had a video or
interactive NFT as their latest mint.
Only sets og:image to an image type.
Image was not displaying with profiles in which had a video or
interactive NFT as their latest mint.
Only sets og:image to an image type.
artist as it looks quite ugly.
as it looked quite ugly.
@yangwao
Copy link
Member

yangwao commented Apr 22, 2021

Do you think you could stretch your PR to other OG-related issues we have?
There are also bounties :)
You can feel free to set netlify setup or preview through PR here.
#117
#118

@miguel-quezada63
Copy link
Contributor Author

@yangwao I will take a look at these other issues. I left some comments on them in order to get some clarification. Whenever you get the chance may you please take a look.

@yangwao
Copy link
Member

yangwao commented Apr 29, 2021

Yes, @miguel-quezada63 just replied #287 (comment) :)
Found there is also #243 issue which could be merged with this

@yangwao
Copy link
Member

yangwao commented Apr 30, 2021

Checking through https://cards-dev.twitter.com/validator url https://deploy-preview-306--nftkodadot.netlify.app/rmrk/u/Dx6nVUy6f2znn4ZwNZ3TGbEyUz3FLbCRGQGKAut4LxjCVRs
looks neat @miguel-quezada63
image

@yangwao yangwao changed the title Resolved issue #287 Showing last NFT mint from user profile in OG:image May 3, 2021
@yangwao
Copy link
Member

yangwao commented May 5, 2021

Hey, @miguel-quezada63 let me merge this as it's feasible to work.
Post your KSM address.
We owe you a bounty ~ $100 :)

Feel free to continue on

there are bounties too!

@yangwao yangwao merged commit c3afc06 into kodadot:main May 5, 2021
@miguel-quezada63
Copy link
Contributor Author

@yangwao definitely will continue to work on other issues related to SEO.

For the bounty, my KSM address is:
JFPBQxThSDUwMYAerdBssm7u7KJBf966u5MMysnC5pB2rgo

@yangwao
Copy link
Member

yangwao commented May 5, 2021

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants