Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search url doesn't update #2100

Closed
1 task done
petersopko opened this issue Jan 28, 2022 · 3 comments · Fixed by #2309
Closed
1 task done

search url doesn't update #2100

petersopko opened this issue Jan 28, 2022 · 3 comments · Fixed by #2309
Labels
$$ ~51-150usd bug Something isn't working p2 core functionality, or is affecting 60% of app v2.2

Comments

@petersopko
Copy link
Contributor

What happened?

while fixing another issue, I've discovered that search in gallery doesn't react to changes as I'd expect it to.
image

Please reproduce in steps

  1. go to https://kodadot.xyz/rmrk/gallery/

  2. search random term such as 'random test search bar' and hit enter

  3. notice this term has appeared in URL -> https://kodadot.xyz/rmrk/gallery?search=random%20test%20search%20bar

  4. click on sort and filter
    image

  5. delete contents of search bar ('random test search bar' changes to empty search bar)

  6. try either changing order or toggling 'Buy now'

  7. page reloads

  8. URL adds the search criteria, in this case let's say 'Buy now' listed/unlisted but DOESN'T update the search query based on the contents of search bar. URL -> https://kodadot.xyz/rmrk/gallery?search=random%20test%20search%20bar&listed=true

This also happens whenever you change the search query to some other term, but you don't pick one of the suggestions (you click elsewhere on the screen) and then, after toggling listing / unlisting, after reload, search bar stays empty but url and result still shows previous query.

Expected Behavior

I've expected the url and search result itself change after reloading according to what is happening in the search section.

What browsers are you seeing the problem on?

No response

Are you logged in?

No response

At which address did you encounter bug?

No response

Screenshots

.

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@petersopko petersopko added the bug Something isn't working label Jan 28, 2022
@petersopko
Copy link
Contributor Author

petersopko commented Jan 28, 2022

I'd also like to fix this, in case this isn't a feature

@yangwao
Copy link
Member

yangwao commented Jan 28, 2022

Yeah when I was approving initial search url v1.1 it was bit wonky, so yeah this occured to me when founding some edge case!

Let's fix it

@yangwao yangwao added $$ ~51-150usd p2 core functionality, or is affecting 60% of app v2.2 labels Jan 28, 2022
@yangwao
Copy link
Member

yangwao commented Feb 7, 2022

Related #2247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd bug Something isn't working p2 core functionality, or is affecting 60% of app v2.2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants