Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2100 - search url doesn't update #2309

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

petersopko
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
馃憞 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 馃И

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Feb 9, 2022

鉁旓笍 Deploy Preview for koda-nuxt ready!

馃敤 Explore the source changes: baaf39f

馃攳 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/62043787f9360900082671a6

馃槑 Browse the preview: https://deploy-preview-2309--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Feb 10, 2022

pay 100 usd

I found edge case but mitigates at least something
image

@yangwao
Copy link
Member

yangwao commented Feb 10, 2022

馃槏 Perfect, I鈥檝e sent the payout
馃挼 $100 @ 186.76 USD/KSM ~ 0.535 $KSM
馃 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
馃敆 0xd69260012a8a19892d56c0a8d86cff0cf1c603a89ac9237099182d55e354368f

馃獏 Let鈥檚 grab another issue and get rewarded!
馃獎 github.com/kodadot/nft-gallery/issues

@yangwao yangwao merged commit 3e09043 into kodadot:main Feb 10, 2022
@yangwao yangwao added the paid pull-request has been paid label Feb 10, 2022
@petersopko petersopko deleted the #2100-search_url_doesn't_update branch September 13, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search url doesn't update
2 participants