Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master Offers component v2 #3463

Closed
Tracked by #660 ...
yangwao opened this issue Jul 18, 2022 · 12 comments · Fixed by #3692
Closed
Tracked by #660 ...

Master Offers component v2 #3463

yangwao opened this issue Jul 18, 2022 · 12 comments · Fixed by #3692
Assignees
Labels
$$ ~51-150usd A-basilisk issues related to basilisk parachain p3 non-core, affecting less than 40%

Comments

@yangwao
Copy link
Member

yangwao commented Jul 18, 2022

Great idea; I guess we can make a functional component with an address as param and input and merge these three current ones.

When the logged-in user visits /bsx/offers it lands on its own address stats by default, i.e. in my case
/bsx/offers?u=bXgvP2cQzEnPvuPQHRghz9dUYovqzyPhXBRXbNwVCef7nsmqb
where default would be incoming offers

There should be two filters where you can choose

  • F1
    • created offers by particular address
    • incoming offers by particular address
  • F2
    • Active
    • Accepted
    • Withdrawn

When the non-logged user opens it, they should see a global table like at https://beta.kodadot.xyz/bsx/stats, so F1 should be disabled.

The goal would be for anyone/user can see per address offers

  • created
  • incoming
  • global

We can put it under the Stats dropdown in the navbar with the name Offers.

Later it becomes the replacement for current stats

Work can start once the issues below are completed.

Originally posted by @yangwao in #3462 (comment)

@yangwao yangwao added $$ ~51-150usd p3 non-core, affecting less than 40% A-basilisk issues related to basilisk parachain S-blocked-✋ labels Jul 18, 2022
@prachi00
Copy link
Member

👋

@kodabot
Copy link
Collaborator

kodabot commented Jul 19, 2022

ISSUE BLOCKED - issue #3463 is blocked. Please wait until issue is unblocked.

@prachi00
Copy link
Member

I can work on this once unblocked 😊

@petersopko
Copy link
Contributor

Adding comment here to follow from

It would be nice to have some sort of option (maybe toggle) to show only active offers, since those are the ones which will be (I assume) most interesting to the user most of the time

@prachi00
Copy link
Member

Adding comment here to follow from

It would be nice to have some sort of option (maybe toggle) to show only active offers, since those are the ones which will be (I assume) most interesting to the user most of the time

I guess we can add filters like the history table?

@petersopko
Copy link
Contributor

Adding comment here to follow from

It would be nice to have some sort of option (maybe toggle) to show only active offers, since those are the ones which will be (I assume) most interesting to the user most of the time

I guess we can add filters like the history table?

yup, I guess that would be the best way to go, something like this:
image

@prachi00
Copy link
Member

@yangwao how are we keeping the UI for this one? do we have any reference?
like are we giving an option here like Transfer, a dedicated page to check offer for any address?

Screen Shot 2022-07-22 at 4 24 40 PM

@prachi00
Copy link
Member

@yangwao how are we keeping the UI for this one? do we have any reference? like are we giving an option here like Transfer, a dedicated page to check offer for any address?

Screen Shot 2022-07-22 at 4 24 40 PM

@yangwao need a little help with the ui ux part of this oneee

@petersopko petersopko mentioned this issue Jul 29, 2022
89 tasks
@yangwao
Copy link
Member Author

yangwao commented Aug 3, 2022

a dedicated page to check offer for any address?

yes.
check original issue, I've just updated it :)

@yangwao yangwao changed the title Master Offer component v2 Master Offers component v2 Aug 3, 2022
@prachi00
Copy link
Member

prachi00 commented Aug 3, 2022

Okay I'll start working on this one

@prachi00
Copy link
Member

prachi00 commented Aug 4, 2022

@yangwao so when you say F1 filter, do you mean two tabs? where one tab shows
created offers by particular address TABLE
and other shows
incoming offers by particular address TABLE
and at the top we can have a text input field where we can input the particular address?

@prachi00 prachi00 self-assigned this Aug 5, 2022
@kodabot
Copy link
Collaborator

kodabot commented Aug 5, 2022

ASSIGNED - @prachi00 🔒 LOCKED -> Monday, August 8th 2022, 05:13:56 UTC -> 72 hours

prachi00 added a commit that referenced this issue Aug 7, 2022
prachi00 added a commit that referenced this issue Aug 7, 2022
@petersopko petersopko mentioned this issue Aug 8, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd A-basilisk issues related to basilisk parachain p3 non-core, affecting less than 40%
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants