Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3203 add table to show currently standing offers for user #3477

Merged
merged 10 commits into from
Jul 23, 2022
Merged

#3203 add table to show currently standing offers for user #3477

merged 10 commits into from
Jul 23, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jul 19, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2022-07-18 at 9 15 21 PM

@prachi00 prachi00 requested review from a team as code owners July 19, 2022 04:16
@prachi00 prachi00 requested review from Jarsen136 and petersopko and removed request for a team July 19, 2022 04:16
@netlify
Copy link

netlify bot commented Jul 19, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 85a8176
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62dba8e8f2cd45000907bd91
😎 Deploy Preview https://deploy-preview-3477--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao
Copy link
Member

yangwao commented Jul 19, 2022 •
edited
Loading

seems works https://deploy-preview-3477--koda-nuxt.netlify.app/bsx/u/bXgvP2cQzEnPvuPQHRghz9dUYovqzyPhXBRXbNwVCef7nsmqb?tab=offers&page=1

I would sort the newest offers on top by default.

Can we make columns sortable for amount, date and name?

image

@yangwao yangwao mentioned this pull request Jul 19, 2022
Merged
19 tasks
@yangwao yangwao added the A-basilisk issues related to basilisk parachain label Jul 19, 2022
@petersopko
Copy link
Contributor

Can we make columns sortable for amount, date and name?

Can we please make the first column shortened? Perhaps add ... if the name of the nft is too long? Table seems to not be centered.

petersopko
petersopko suggested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left the comment about first column, I guess I meant it in the similar fashion to https://beta.kodadot.xyz/bsx/stats

@petersopko petersopko added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 19, 2022
@prachi00
Copy link
Member Author

Can we make columns sortable for amount, date and name?

Can we please make the first column shortened? Perhaps add ... if the name of the nft is too long? Table seems to not be centered.

done

@prachi00
Copy link
Member Author

seems works https://deploy-preview-3477--koda-nuxt.netlify.app/bsx/u/bXgvP2cQzEnPvuPQHRghz9dUYovqzyPhXBRXbNwVCef7nsmqb?tab=offers&page=1

I would sort the newest offers on top by default.

Can we make columns sortable for amount, date and name?

image

@yangwao done

@prachi00 prachi00 requested a review from petersopko July 19, 2022 20:03
@petersopko
Copy link
Contributor

wfm, just one thing, did we leave out the sorting by offer status on purpose? Maybe it'd be nice to have option to show only active offers since those are the ones which will be most interesting to user? @yangwao wdyt

@yangwao
Copy link
Member

yangwao commented Jul 20, 2022

did we leave out the sorting by offer status on purpose?

seems works on https://beta.kodadot.xyz/bsx/stats/ so let's have it there @prachi00

image

Maybe it'd be nice to have option to show only active offers since those are the ones which will be most interesting to user?

legit, add it here

@petersopko petersopko mentioned this pull request Jul 20, 2022
Closed
@prachi00
Copy link
Member Author

did we leave out the sorting by offer status on purpose?

seems works on https://beta.kodadot.xyz/bsx/stats/ so let's have it there @prachi00

image

Maybe it'd be nice to have option to show only active offers since those are the ones which will be most interesting to user?

legit, add it here

Added sorting in status @yangwao @petersopko

petersopko
petersopko approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@prachi00 prachi00 requested a review from Jarsen136 July 21, 2022 19:56
Jarsen136
Jarsen136 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jarsen136
Jarsen136 reviewed Jul 21, 2022
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet ths query does not meet this point. 👀

image

queries/subsquid/bsx/offerListUser.graphql Show resolved Hide resolved
@petersopko
Copy link
Contributor

@yangwao I see that you've added this reuqest

test if it's showing offers on burned nfts where offers did not expire

did you mean to add some column which will track whether NFT is burned or not? Cause the query right now, is fetching all of the NFTs regardless of their state (so you can see the burned ones in the table)

@yangwao
Copy link
Member

yangwao commented Jul 22, 2022

did you mean to add some column which will track whether NFT is burned or not?

Let's make a separate issue

Cause the query right now, is fetching all of the NFTs regardless of their state (so you can see the burned ones in the table)

✅

@prachi00
Copy link
Member Author

did you mean to add some column which will track whether NFT is burned or not?

Let's make a separate issue

Cause the query right now, is fetching all of the NFTs regardless of their state (so you can see the burned ones in the table)

✅

yeah I can make that but kinda need more clarity on this one

@prachi00 prachi00 mentioned this pull request Jul 22, 2022
Closed
@prachi00
Copy link
Member Author

pay 250 usd

@yangwao
Copy link
Member

yangwao commented Jul 22, 2022

😍 Perfect, I’ve sent the payout
💵 $250 @ 68.3 USD/KSM ~ 3.66 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xe2b576022bf77da2d6934e5e464a1821a48211db7c408ac6e1ee4b134b806902

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 22, 2022
@prachi00 prachi00 enabled auto-merge July 22, 2022 17:07
@prachi00 prachi00 merged commit b46850b into main Jul 23, 2022
@prachi00 prachi00 deleted the feat-add-offer-user branch July 23, 2022 07:57
@prachi00 prachi00 mentioned this pull request Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@petersopko petersopko petersopko approved these changes

Assignees
No one assigned
Labels
A-basilisk issues related to basilisk parachain paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add page to show currently standing offers for user
4 participants
@prachi00 @yangwao @petersopko @Jarsen136