Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On focus in search box we should suggest trending collections #4141

Closed
yangwao opened this issue Oct 19, 2022 · 5 comments · Fixed by #4181
Closed

On focus in search box we should suggest trending collections #4141

yangwao opened this issue Oct 19, 2022 · 5 comments · Fixed by #4181
Assignees
@prachi00
Labels
$$ ~51-150usd A-search related to search components p2 core functionality, or is affecting 60% of app redesign

Comments

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022 •
edited
Loading

On focus in searchbox we should suggest trending collections + search history, like last 3 searched terms

@exezbcz can edit this to add Figma link but I guess it was in original one?

image

image

Originally posted by @yangwao in #4127 (comment)
@yangwao yangwao added p2 core functionality, or is affecting 60% of app A-search related to search components redesign $$$ ~151-300usd labels Oct 19, 2022
@yangwao yangwao mentioned this issue Oct 19, 2022
Closed
@exezbcz
Copy link
Member

exezbcz commented Oct 19, 2022

image
yup it's in the original landing page handoff
https://www.figma.com/file/3iOjW12ERFRDSVnpLuhQmf/landing-page-handoff?node-id=1305%3A5613

@prachi00
Copy link
Member

we already had search history in our current old implementation right or did we remove that?

@Jarsen136
Copy link
Contributor

we already had search history in our current old implementation right or did we remove that?

You are right and we could bring them back.

@Jarsen136
Copy link
Contributor

On focus in searchbox we should suggest trending collections + search history, like last 3 searched terms

For now only on RMRK, the trending suggestion would be show.
image

@prachi00 prachi00 self-assigned this Oct 23, 2022
@kodabot
Copy link
Collaborator

kodabot commented Oct 23, 2022

ASSIGNED - @prachi00 🔒 LOCKED -> Thursday, October 27th 2022, 12:29:30 UTC -> 108 hours

prachi00 added a commit that referenced this issue Oct 26, 2022
@prachi00
#4141 On focus in search box show history
e2aa623
@prachi00 prachi00 mentioned this issue Oct 26, 2022
Merged
18 tasks
@yangwao yangwao added $$ ~51-150usd and removed $$$ ~151-300usd labels Oct 28, 2022
yangwao added a commit that referenced this issue Oct 28, 2022
@yangwao
Merge pull request #4181 from kodadot/feat-show-history
99d7c44 
#4141 On focus in search box show history
@yangwao yangwao mentioned this issue Oct 28, 2022
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prachi00 prachi00

Labels
$$ ~51-150usd A-search related to search components p2 core functionality, or is affecting 60% of app redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4141 On focus in search box show history kodadot/nft-gallery
5 participants
@yangwao @Jarsen136 @prachi00 @exezbcz @kodabot