Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 💄 release redesigned landing page #4127

Merged
merged 7 commits into from
Oct 19, 2022
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Oct 17, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • Requires deployment <rubick/magick_issue>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2022-10-19 at 11 26 24

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit bace2ce
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/634f7a188c756200095978db
😎 Deploy Preview https://deploy-preview-4127--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review October 17, 2022 08:44
@preschian preschian requested review from a team as code owners October 17, 2022 08:44
@preschian preschian requested review from kkukelka and petersopko and removed request for a team October 17, 2022 08:44
@preschian
Copy link
Member Author

this is the PR when we ready to release the new design to the public without params
cc @yangwao

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KodadotSocialLinks isn't used? :( not even in footer?
You can remove/rename TopCollection component (new is ReTopCollection)

@preschian
Copy link
Member Author

preschian commented Oct 17, 2022

KodadotSocialLinks isn't used? :( not even in footer?

it seems no component is using it. in the new footer use the array list https://github.com/kodadot/nft-gallery/blob/main/components/TheFooter.vue#L126

You can remove/rename TopCollection component (new is ReTopCollection)

noted 👍

@yangwao
Copy link
Member

yangwao commented Oct 17, 2022

this is the PR when we ready to release the new design to the public without params

oh, perfect, been looking for this one too :)

I guess we are close to wrapping up once there will be navbar

@vikiival
Copy link
Member

Setting up as draft until #4063 is merged

@vikiival vikiival marked this pull request as draft October 17, 2022 13:32
@yangwao
Copy link
Member

yangwao commented Oct 18, 2022

Probably once this is merged

@yangwao yangwao marked this pull request as ready for review October 18, 2022 14:33
@yangwao
Copy link
Member

yangwao commented Oct 18, 2022

let's resolve conflicts @preschian and let it fly

@codeclimate
Copy link

codeclimate bot commented Oct 19, 2022

Code Climate has analyzed commit bace2ce and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

On focus in searchbox we should suggest trending collections

image

Will make extra issue

Copy link
Member

@yangwao yangwao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally!

@yangwao yangwao merged commit a923c30 into main Oct 19, 2022
@yangwao yangwao deleted the release-redesign-landing-page branch October 19, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants