Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close sidebar on network change #5942

Closed
yangwao opened this issue May 12, 2023 · 1 comment · Fixed by #5964
Closed

close sidebar on network change #5942

yangwao opened this issue May 12, 2023 · 1 comment · Fixed by #5964
Assignees
@Jarsen136
Labels
A-sidebar related to sidebars p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented May 12, 2023

  • if i select the BSX network, check my balances and then change to RMRK without closing the modal it still shows my BSX balances:

I would propose to close sidebar on network change till now

Originally posted by @yangwao in #5400 (comment)
@yangwao yangwao added p2 core functionality, or is affecting 60% of app A-sidebar related to sidebars labels May 12, 2023
@yangwao yangwao mentioned this issue May 12, 2023
Merged
8 tasks
@Jarsen136 Jarsen136 self-assigned this May 13, 2023
@kodabot
Copy link
Collaborator

kodabot commented May 13, 2023

ASSIGNED - @Jarsen136 🔒 LOCKED -> Sunday, May 14th 2023, 15:57:40 UTC -> 36 hours

@Jarsen136 Jarsen136 mentioned this issue May 14, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jarsen136 Jarsen136

Labels
A-sidebar related to sidebars p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: close sidebar on network change Jarsen136/nft-gallery
3 participants
@yangwao @Jarsen136 @kodabot