✨ migrate Identity store to pinia #5400

roiLeo · 2023-03-28T13:13:29Z

This one need to be tested (doesn't work yet)
edit: Tested new minting on /snek/gallery/3124270296-1

TODO

onChange account fetchBalance is triggered but new value not diplayed
onLoad app doesn't show WalletName
[Vue warn]: Write operation failed: computed value is readonly
issue with subapi (connect to bsx on rmrk chain???)
> After connect, if realod, it doesn't stay connected (the wallet) Balance is not loaded properly of compare with beta
rmrk2 not loading on first open wallet sidebar

PR Type

Refactoring

Context

related link Replace vuex with pinia/useState #4755

Screenshot 📸

updated:

Copilot philosophy

`🤖 Generated by Copilot at 23b3c6a`

Summary

Walkthrough

stores/identity.ts

netlify · 2023-03-28T13:17:43Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`9460a83`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/645e6249aa122f00088b5071
😎 Deploy Preview	https://deploy-preview-5400--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

stores/identity.ts

roiLeo · 2023-04-05T15:24:33Z

wassup

reviewpad · 2023-04-05T15:24:47Z

Reviewpad Report

⚠️ Warnings

Please link an issue to the pull request

reviewpad · 2023-04-07T14:52:06Z

AI-Generated Summary: This pull request involves updates to several components and store files, with the primary focus on refactoring the handling of user identities and account balances. The code now utilizes a new identity store instead of the previous Vuex store structure. Major changes include importing useIdentityStore from '@/stores/identity', replacing instances of $store with identityStore, and updating getter methods and computed properties to use the new identityStore.

In addition, the nuxt.config.js file has been updated with the removal of the userBalance plugin, and the entire identity.ts Vuex store file has been deleted. A new file stores/identity.ts has been added, implementing an improved store for managing user identities and balances.

Overall, these changes aim to enhance code maintainability and readability, and leverage the new identity store for more effective account management.

yangwao · 2023-04-09T14:23:14Z

wassup

reviewpad · 2023-04-12T11:57:57Z

AI-Generated Summary: This pull request includes changes to various components, stores, and utilities of the application to improve authentication state management and modularization. The changes primarily involve replacing previous usage of Vuex stores with a new identity store, useIdentityStore, which is imported from '@/stores/identity'. This identity store is now used to handle authentication, balances, and identities more effectively. Additionally, the userBalance plugin and the entire store/identity.ts file have been deleted, and several components, such as Navbar.vue and AccountBalance.vue have been updated with the new identity store implementation. The changes made to the emitAccountChange method of some components involve emitting an account object instead of just the address string. Overall, the changes lead to a more streamlined and modular codebase, easier maintenance, and better separation of concerns within the application.

reviewpad · 2023-04-12T12:30:02Z

AI-Generated Summary: This pull request includes changes to various components, initially focusing on the implementation of a new useIdentityStore from '@/stores/identity' to manage identity and authentication states. The changes also refactor components to use this new store instead of directly accessing the Vuex store or other variables. The main updates involve the replacement of $store getters and actions with corresponding methods and properties from useIdentityStore, making the components more maintainable and easier to test. Additionally, some components have had their methods updated, such as the conversion of the balanceOf method from a getter to a regular method. Some functions and plugins related to user balance and address formatting have been commented out or removed, possibly for testing or refactoring purposes. Overall, the pull request aims to improve code structure, organization, and consistency in handling identity and authentication states across various components.

vikiival · 2023-04-12T17:43:50Z

wassup

Clicked this magic button

stores/identity.ts

store/index.ts

pages/transfer.vue

composables/useAuth.ts

vikiival · 2023-05-03T15:47:14Z

@kodadot/qa-guild pls

Need to test if we have correct token amounts on chain and correct identities

vikiival · 2023-05-03T15:47:20Z

cc @helloitsdamsky

daiagi

wfm

stores/identity.ts

yangwao · 2023-05-08T19:51:22Z

identity should work, right?
bc I don't see it working

also balance bug found prob not related to this pr

Screen.Recording.2023-05-08.at.21.50.43.mov

yangwao · 2023-05-08T19:54:16Z

on Mar 28

I would merge bc it's open quite long here

roiLeo · 2023-05-09T07:09:53Z

I would merge bc it's open quite long here

Feel free but I'll let you know this could break some part of app.

IDK why but on RMRK2 sometimes it's fetching balance from BSX rpc endpoint.

edit: now doesn't work on rmrk2... 😮‍💨

daiagi · 2023-05-09T09:54:13Z

I would merge bc it's open quite long here

Feel free but I'll let you know this could break some part of app.

IDK why but on RMRK2 sometimes it's fetching balance from BSX rpc endpoint.

edit: now doesn't work on rmrk2... face_exhaling

seems related with

Balance bug on rmrk2 #5838

roiLeo · 2023-05-09T10:00:31Z

seems related with

* [Balance bug on rmrk2 #5838](https://github.com/kodadot/nft-gallery/issues/5838)

Maybe something wrong with sub-api package as I don't have the good apiInstance when ksm (rmrk2) prefix

yangwao · 2023-05-10T12:22:47Z

Feel free but I'll let you know this could break some part of app.

okay can wait probably, yet we want to deploy rmrk2 to production

yangwao · 2023-05-10T20:17:32Z

hmm, did not help apparently

🚑 default prefix is not your default prefix #5914

yangwao · 2023-05-10T20:18:35Z

testing on this one

https://deploy-preview-5400--koda-canary.netlify.app/ksm/collection/22708b368d163c8007-CITY/activity

prury · 2023-05-11T16:52:21Z

testing on this one

* https://deploy-preview-5400--koda-canary.netlify.app/ksm/collection/22708b368d163c8007-CITY/activity

Loading times are longer than beta.kodadot.xyz
if i select the BSX network, check my balances and then change to RMRK without closing the modal it still shows my BSX balances:

Balances from Kusama won't load, only if change to another network and try again, or refresh the page, also, taking lots of times to fetch balances:

yangwao · 2023-05-11T19:22:58Z

if i select the BSX network, check my balances and then change to RMRK without closing the modal it still shows my BSX balances:

this was might fixed in

💥 take url by prefix #5927
I can try update this PR and let's see

May be related too PR above

codeclimate · 2023-05-12T15:59:41Z

Code Climate has analyzed commit 9460a83 and detected 0 issues on this pull request.

View more on Code Climate.

yangwao · 2023-05-12T19:42:12Z

if i select the BSX network, check my balances and then change to RMRK without closing the modal it still shows my BSX balances:

I would propose to close sidebar on network change till now, I've made follow up in #5942 cc @prury

Balances from Kusama won't load, only if change to another network and try again, or refresh the page, also, taking lots of times to fetch balances:

worked for me

yangwao · 2023-05-12T19:43:57Z

prepare for bugs

roiLeo added 2 commits March 28, 2023 15:11

✨ migrate Identity store to pinia

0e4a526

Merge branch 'main' into chore/pinia/identity

19ecd0c

roiLeo mentioned this pull request Mar 28, 2023

Replace vuex with pinia/useState #4755

Closed

codeclimate bot reviewed Mar 28, 2023

View reviewed changes

stores/identity.ts Outdated Show resolved Hide resolved

roiLeo added 3 commits March 31, 2023 14:01

✨ wip: identity store

46e08e5

Merge branch 'main' into chore/pinia/identity

7637ee8

✨ wip: migrate identity store

a4d20c5

codeclimate bot reviewed Apr 5, 2023

View reviewed changes

stores/identity.ts Outdated Show resolved Hide resolved

roiLeo and others added 2 commits April 5, 2023 17:11

✨ identity store migration to pinia

c5f8338

Merge branch 'main' into chore/pinia/identity

2bf577d

reviewpad bot mentioned this pull request Apr 5, 2023

feat: reviewpad onboarding #5277

Merged

reviewpad bot added the large Pull request is large label Apr 5, 2023

Merge branch 'main' into chore/pinia/identity

024d6f4

✨ wip: migrate identity store

d187dfc

roiLeo marked this pull request as ready for review April 12, 2023 12:27

roiLeo requested a review from a team as a code owner April 12, 2023 12:27

roiLeo requested review from vikiival and daiagi and removed request for a team April 12, 2023 12:27

reviewpad bot added the waiting-for-review label Apr 12, 2023

✨ migrate identity store

d7405d4

daiagi suggested changes Apr 13, 2023

View reviewed changes

stores/identity.ts Outdated Show resolved Hide resolved

store/index.ts Outdated Show resolved Hide resolved

pages/transfer.vue Outdated Show resolved Hide resolved

composables/useAuth.ts Show resolved Hide resolved

daiagi approved these changes May 4, 2023

View reviewed changes

stores/identity.ts Show resolved Hide resolved

daiagi added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 4, 2023

roiLeo added 2 commits May 4, 2023 08:36

Merge branch 'main' into chore/pinia/identity

6844f7b

🔧 replace useLocalStorage

6f3a295

Merge branch 'main' into chore/pinia/identity

89544ca

🔧 identity

82da9cc

roiLeo and others added 2 commits May 10, 2023 15:01

🔧 resolve conflicts

d487cb0

Merge branch 'main' into chore/pinia/identity

0947fba

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 11, 2023

yangwao and others added 2 commits May 11, 2023 21:23

Merge branch 'main' into chore/pinia/identity

2779760

🔧 resolve conflicts

9460a83

yangwao mentioned this pull request May 12, 2023

close sidebar on network change #5942

Closed

yangwao merged commit 665fd17 into kodadot:main May 12, 2023
12 of 15 checks passed

yangwao mentioned this pull request May 13, 2023

Unable to retrieve keypair on canary for transfer #5956

Closed

roiLeo mentioned this pull request May 23, 2023

Refactor get.balance() #4142

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ migrate Identity store to pinia #5400

✨ migrate Identity store to pinia #5400

roiLeo commented Mar 28, 2023 •

edited

Loading

netlify bot commented Mar 28, 2023 •

edited

Loading

roiLeo commented Apr 5, 2023

reviewpad bot commented Apr 5, 2023 •

edited

Loading

reviewpad bot commented Apr 7, 2023

yangwao commented Apr 9, 2023

reviewpad bot commented Apr 12, 2023

reviewpad bot commented Apr 12, 2023

vikiival commented Apr 12, 2023

vikiival commented May 3, 2023

vikiival commented May 3, 2023

daiagi left a comment

yangwao commented May 8, 2023

yangwao commented May 8, 2023 •

edited

Loading

roiLeo commented May 9, 2023 •

edited

Loading

daiagi commented May 9, 2023

roiLeo commented May 9, 2023 •

edited

Loading

yangwao commented May 10, 2023

yangwao commented May 10, 2023

yangwao commented May 10, 2023

prury commented May 11, 2023

yangwao commented May 11, 2023

codeclimate bot commented May 12, 2023

yangwao commented May 12, 2023 •

edited

Loading

yangwao commented May 12, 2023

✨ migrate Identity store to pinia #5400

✨ migrate Identity store to pinia #5400

Conversation

roiLeo commented Mar 28, 2023 • edited Loading

TODO

PR Type

Context

Screenshot 📸

Copilot philosophy

🤖 Generated by Copilot at 23b3c6a

Summary

Walkthrough

netlify bot commented Mar 28, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

roiLeo commented Apr 5, 2023

reviewpad bot commented Apr 5, 2023 • edited Loading

reviewpad bot commented Apr 7, 2023

yangwao commented Apr 9, 2023

reviewpad bot commented Apr 12, 2023

reviewpad bot commented Apr 12, 2023

vikiival commented Apr 12, 2023

vikiival commented May 3, 2023

vikiival commented May 3, 2023

daiagi left a comment

Choose a reason for hiding this comment

yangwao commented May 8, 2023

yangwao commented May 8, 2023 • edited Loading

roiLeo commented May 9, 2023 • edited Loading

daiagi commented May 9, 2023

roiLeo commented May 9, 2023 • edited Loading

yangwao commented May 10, 2023

yangwao commented May 10, 2023

yangwao commented May 10, 2023

prury commented May 11, 2023

yangwao commented May 11, 2023

codeclimate bot commented May 12, 2023

yangwao commented May 12, 2023 • edited Loading

yangwao commented May 12, 2023

roiLeo commented Mar 28, 2023 •

edited

Loading

`🤖 Generated by Copilot at 23b3c6a`

netlify bot commented Mar 28, 2023 •

edited

Loading

reviewpad bot commented Apr 5, 2023 •

edited

Loading

yangwao commented May 8, 2023 •

edited

Loading

roiLeo commented May 9, 2023 •

edited

Loading

roiLeo commented May 9, 2023 •

edited

Loading

yangwao commented May 12, 2023 •

edited

Loading