Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close sidebar on network change #5964

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: close sidebar on network change #5964

merged 1 commit into from
May 16, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 14, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at dd02484

Improved network switching in ConnectWalletModal.vue by using URL prefix from store and closing modal on change.

🤖 Generated by Copilot at dd02484

Oh, we're the brave developers of the Nuxt app
We import the instance and we get the prefix from the store
We close the modal when the network switches, that's a fact
And we heave away and code some more

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 14, 2023 15:19
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team May 14, 2023 15:19
@kodabot
Copy link
Collaborator

kodabot commented May 14, 2023

SUCCESS @Jarsen136 PR for issue #5942 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 14, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit dd02484
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6460fc00ea12bc0008fa9572
😎 Deploy Preview https://deploy-preview-5964--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented May 14, 2023

Code Climate has analyzed commit dd02484 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 14, 2023

AI-Generated Summary: This pull request includes a fix for closing the sidebar when the network changes. The patch adds a watch to the urlPrefix from the Vuex store and emits a 'close' event to close the sidebar when the value changes. This ensures that the sidebar is closed and the user's focus is redirected to the relevant content when the network is switched.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 14, 2023
roiLeo
roiLeo approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm

components/common/ConnectWallet/ConnectWalletModal.vue
const identityStore = useIdentityStore()

// urlPrefix from usePrefix() would not update inside modal component
const urlPrefix = computed(() => $store.getters.currentUrlPrefix)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... this is strange prefix should be based on this value too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5984, time to update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why urlPrefix does not update using usePrefixin the modal component. Maybe leave it to #5984 for deeper invigorate.

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 15, 2023
@yangwao
Copy link
Member

yangwao commented May 16, 2023

yes, it's better, there is still glitch missing bug on balance on initial but we are getting there

Screen.Recording.2023-05-16.at.12.24.17.mov

@yangwao
Copy link
Member

yangwao commented May 16, 2023

pay 30 usd

@yangwao yangwao merged commit e3e5fa4 into kodadot:main May 16, 2023
@yangwao
Copy link
Member

yangwao commented May 16, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 25.59 USD/KSM ~ 1.172 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x801ed6c1ab8ba41cafa662e31769859613ee4ceaaa55a76b8121f8a6568df119

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 16, 2023
This was referenced May 16, 2023
Closed
Merged
Merged
Merged
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

close sidebar on network change
4 participants
@Jarsen136 @kodabot @yangwao @roiLeo