Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: New wallets: Autoteleport: Got stuck on checking funds #10264

Merged
merged 5 commits into from
May 14, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented May 8, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • there is a discrepancy between the amount that should arrive and the amount arriving, probably its the delivery fee, that atm it's not being accounted for by polkadot js

  • tried with 0 DOT on ahp account and the balance check was successful

  • Closes New wallets: Autoteleport: Got stuck on checking funds #10225

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-05-08.at.12.21.12.mp4

@hassnian hassnian requested a review from a team as a code owner May 8, 2024 08:33
@hassnian hassnian requested review from vikiival and daiagi and removed request for a team May 8, 2024 08:33
Copy link

netlify bot commented May 8, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ec433d8
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66422913322fc10008400dd1
😎 Deploy Preview https://deploy-preview-10264--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 8, 2024
@prury
Copy link
Member

prury commented May 8, 2024

problem still persists here:

hassnian-checkinfunds.webm

@hassnian
Copy link
Contributor Author

hassnian commented May 9, 2024

@prury try again

thanks

CleanShot.2024-05-09.at.13.33.31.mp4

@prury
Copy link
Member

prury commented May 9, 2024

@prury try again

tried again, checking funds error seems to be gone, cancelled mint and tried again, received an error that i was not receiving before:

Gravacao.de.tela.de.09-05-2024.10.44.37.webm

@prury
Copy link
Member

prury commented May 10, 2024

ok, checking funds works properly, the other error is not related to this PR

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels May 10, 2024
@vikiival
Copy link
Member

cc @daiagi

Copy link

codeclimate bot commented May 13, 2024

Code Climate has analyzed commit ec433d8 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JustLuuuu
Copy link
Member

A peson just got stuck again on checking funds.

@vikiival
Copy link
Member

@JustLuuuu can you please test if this works?

@JustLuuuu
Copy link
Member

@JustLuuuu can you please test if this works?

looks like working - tested on a new wallet. good to release

@vikiival vikiival merged commit b94756c into kodadot:main May 14, 2024
19 checks passed
@hassnian hassnian deleted the issue-10225 branch May 15, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New wallets: Autoteleport: Got stuck on checking funds
4 participants