-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Paid mint modal auto-teleport flow #10258
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
i was testing and normal flow went ok, but then i started facing issues with auto-teleport that we are solving in #10264 , let's wait for it to be merged. So far one modal at time was working ok |
What drop are you using to do the tests ? I tested it with meadow and worked fine , didn't face that issue once #10264 it's only happening with hdd drop isn't ? These two issue are not related , and should be able to be solved independently , but we can wait. Is the balance check issue also happening in other drops ? |
sorry for the lack of info, but yes, it also happened on meadow. |
cc @daiagi |
cc @prury ? |
Code Climate has analyzed commit 09fc737 and detected 0 issues on this pull request. View more on Code Climate. |
i was OOO |
@hassnian i think we are good, only thing i was found uncommon was loading modal between some steps(1:56), but its coming from canary, so. overlapping modals seems to be solved, and modals seems to be appearing in right places at the right time. whole autoteleport + autoteleport process: Gravacao.de.tela.de.16-05-2024.10.25.55.webm |
@JustLuuuu can u please check? |
I think its ok |
Quality Gate passedIssues Measures |
PR Type
Context
@prury pls test theses 3 flows
I've attached bellow videos for each one , thanks
errors
whileauto teleporting
#10253Needs QA check
Needs Design check
Did your issue had any of the "$" label on it?
Screenshot 📸
paid mint auto teleport
CleanShot.2024-05-07.at.16.04.58.mp4
paid mint normal flow
CleanShot.2024-05-07.at.17.05.32.mp4
testing multiple autotelport in one session
CleanShot.2024-05-08.at.16.59.18.mp4