Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: waiting times for mint #11088

Merged
merged 4 commits into from
Oct 8, 2024
Merged

fix: waiting times for mint #11088

merged 4 commits into from
Oct 8, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 7, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

reviewers could you guys also test, thanks

  • perf: faster sub wallet balance fetching (now using the the sub api)
  • fix: auto teleport fetching balances when not needed
  • Closes waiting times for mint  #10663

Needs QA check

Screenshot 📸

  • My fix has changed something on UI;

Balance fetching

Now (fast) 🚀

CleanShot 2024-10-07 at 15 15 26

Prev (Slow) 😅

CleanShot 2024-10-07 at 15 19 38

Faster drop minting experience

CleanShot.2024-10-07.at.15.07.22.mp4

Auto teleport

CleanShot.2024-10-07.at.15.10.44.mp4

@hassnian hassnian requested a review from a team as a code owner October 7, 2024 10:03
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team October 7, 2024 10:03
Copy link

sonarcloud bot commented Oct 7, 2024

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit bd37dd4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6703b234c7b7f300086449e4
😎 Deploy Preview https://deploy-preview-11088--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 8, 2024
@vikiival vikiival added this pull request to the merge queue Oct 8, 2024
Merged via the queue into kodadot:main with commit 791073c Oct 8, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waiting times for mint
4 participants