Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Updated polkadot@7.4 and other funky issues #1950

Merged
merged 8 commits into from
Jan 20, 2022
Merged

🎉 Updated polkadot@7.4 and other funky issues #1950

merged 8 commits into from
Jan 20, 2022

Conversation

vikiival
Copy link
Member

  • 🚧 new api
  • 🧹 removed {isDev} from nuxt.config
  • 📝 commented out forgoten toolbox
  • 🔝 updated @PolkaDot packages
  • 🚚 moved plugins/api to plugins/polkadot
  • ⚡ removed cryptoWaitReady from the templates

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

@vikiival vikiival self-assigned this Jan 19, 2022
@netlify
Copy link

netlify bot commented Jan 19, 2022 •
edited
Loading

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: b114678

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61e9249dc085790008cf01f5

😎 Browse the preview: https://deploy-preview-1950--koda-nuxt.netlify.app

roiLeo
roiLeo reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes finally!
How did you manage to move code outside layout? What does it change? We only have to keep polkadot plugin?

@vikiival
Copy link
Member Author

How did you manage to move code outside layout?

The docs said that you should call crypto ready only once and since I had access to the store in plugins It was a great choice

We only have to keep the polkadot plugin?

Yup!

@vikiival
Merge remote-tracking branch 'origin/main' into new-apii
ac798b1 
# Conflicts:
#	package.json
#	yarn.lock
@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

Gif

@yangwao yangwao mentioned this pull request Jan 20, 2022
Open
@yangwao
Copy link
Member

yangwao commented Jan 20, 2022

Seems related to

@yangwao
Copy link
Member

yangwao commented Jan 20, 2022

Works way faster tho!

@yangwao yangwao merged commit 1b6d658 into main Jan 20, 2022
@vikiival vikiival deleted the new-apii branch January 20, 2022 12:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo left review comments

@yangwao yangwao Awaiting requested review from yangwao

Assignees

@vikiival vikiival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikiival @yangwao @roiLeo