Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar breakpoints to hide tab #2769

Merged
merged 5 commits into from
Apr 5, 2022
Merged

Navbar breakpoints to hide tab #2769

merged 5 commits into from
Apr 5, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 4, 2022 13:43
@Jarsen136 Jarsen136 requested review from roiLeo and removed request for a team April 4, 2022 13:43
@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 4f09d8c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/624c03d7194f7000086d8223
😎 Deploy Preview https://deploy-preview-2769--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136
Copy link
Contributor Author

When the screen width is less than 1024px, it is for mobile devices.

@roiLeo
Copy link
Contributor

roiLeo commented Apr 4, 2022

/giphy wheel fortune

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check these responsive helpers

@Jarsen136
Copy link
Contributor Author

You should check these responsive helpers

Thanks, it's helpful. However, in this case these ranges are not precise enough, we need to accurately control the display of each tab.
image

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is mobile menu:
Screenshot 2022-04-04 at 16-04-09 KodaDot - Kusama NFT Market Explorer

  • I'm not able to change language
  • I'm not able to change chain
  • i'm not able to create

Instead of hiding item from navbar I would try to:

  • a. make searchBar responsive (reduce the size from screen width)
  • b. enlarge mobile menu
  • c. create a new dropdown (...) with the other buttons

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Apr 4, 2022

  • I'm not able to change language
  • I'm not able to change chain
  • i'm not able to create

Instead of hiding item from navbar I would try to:

  • a. make searchBar responsive (reduce the size from screen width)
  • b. enlarge mobile menu
  • c. create a new dropdown (...) with the other buttons

Great eyesight! Now it can show every tab on the mobile menu.
How about now 👀
image

a. make searchBar responsive (reduce the size from screen width)

BTW, this can also be done, but it is different from the description of the original issue. What do you think @yangwao

@yangwao
Copy link
Member

yangwao commented Apr 4, 2022

BTW, this can also be done, but it is different from the description of the original issue. What do you think @yangwao

yes, if you notice, the search bar fixed width was probably root issue of all of this :)

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Apr 4, 2022

Okay, now this searchBar is responsive. 👀

@yangwao
Copy link
Member

yangwao commented Apr 5, 2022

I mean previous hiding technique was a great approach.
Maybe just hide out chain selector and language, so the search bar won't look bad if someone use it, for example, someone is using a split-screen on 13"

1110px width
image

@Jarsen136
Copy link
Contributor Author

I mean previous hiding technique was a great approach. Maybe just hide out chain selector and language, so the search bar won't look bad if someone use it, for example, someone is using a split-screen on 13"

1110px width image

Oh I misread what you meant. Let me revert to the original state

@yangwao
Copy link
Member

yangwao commented Apr 5, 2022

I mean previous hiding technique was a great approach. Maybe just hide out chain selector and language, so the search bar won't look bad if someone use it, for example, someone is using a split-screen on 13"
1110px width image

Oh I misread what you meant. Let me revert to the original state

yes, a flexible search bar with hiding would be great I guess! :)

yes, in the previous state was an issue that search bar was fixed :)

@Jarsen136
Copy link
Contributor Author

yes, a flexible search bar with hiding would be great I guess! :)

yes, in the previous state was an issue that search bar was fixed :)

How about now? 👀 shorten the width of search-bar first, and then hide out language and chain selector

@yangwao
Copy link
Member

yangwao commented Apr 5, 2022

I mean way better, I guess we will rework the whole navbar later :)

image

@yangwao
Copy link
Member

yangwao commented Apr 5, 2022

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Apr 5, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 191.64 USD/KSM ~ 0.522 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xfd0992102b23d4b9b9b3c73967cc03fc133b499c62dc94a61f3ee0cb9418e205

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 5, 2022
@yangwao
Copy link
Member

yangwao commented Apr 5, 2022

We should rework and refactor the navbar code in a much more sensible way and what's should be merged and exclude on different widths.

Hidding least popular buttons from first, hence we don't have any UX research I can only bet.

  • language
  • chain/protocol selector
  • create
  • history
  • stats
  • profile

With search bar should be flexible and fill up the rest space next to the buttons.

@yangwao yangwao merged commit e588780 into kodadot:main Apr 5, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar breakpoints on 1037px
3 participants