-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navbar breakpoints to hide tab #2769
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
When the screen width is less than 1024px, it is for mobile devices. |
/giphy wheel fortune |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check these responsive helpers
Thanks, it's helpful. However, in this case these ranges are not precise enough, we need to accurately control the display of each tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great eyesight! Now it can show every tab on the mobile menu.
BTW, this can also be done, but it is different from the description of the original issue. What do you think @yangwao |
yes, if you notice, the search bar fixed width was probably root issue of all of this :) |
Okay, now this searchBar is responsive. 👀 |
How about now? 👀 shorten the width of search-bar first, and then hide out language and chain selector |
pay 100 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
We should rework and refactor the navbar code in a much more sensible way and what's should be merged and exclude on different widths. Hidding least popular buttons from first, hence we don't have any UX research I can only bet.
With search bar should be flexible and fill up the rest space next to the buttons. |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot