Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2838 Link in /collection/{id} are broken on beta #2842

Merged
merged 2 commits into from
Apr 13, 2022
Merged

#2838 Link in /collection/{id} are broken on beta #2842

merged 2 commits into from
Apr 13, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Apr 13, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@prachi00 prachi00 requested a review from a team as a code owner April 13, 2022 09:26
@prachi00 prachi00 requested review from roiLeo and removed request for a team April 13, 2022 09:26
@netlify
Copy link

netlify bot commented Apr 13, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 7ba355c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/625698de1335640008d982f8
😎 Deploy Preview https://deploy-preview-2842--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

roiLeo
roiLeo approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup tested, code lgtm

@roiLeo
Copy link
Contributor

roiLeo commented Apr 13, 2022

pay 50

@yangwao
Copy link
Member

yangwao commented Apr 13, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 153.8 USD/KSM ~ 0.325 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x5c78a66d92103921edbc5a4b2dce3405f268ee0c8d10889f241e187552f2b6f8

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@roiLeo roiLeo merged commit 39409b4 into kodadot:main Apr 13, 2022
@yangwao yangwao added the paid pull-request has been paid label Apr 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link in /collection/{id} are broken on beta
3 participants
@prachi00 @roiLeo @yangwao