Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ gallery order by Most emoted #2905

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Apr 26, 2022

PR type

  • Feature

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

  • Fill up your KSM address: Payout

Screenshot

Capture d’écran 2022-04-26 à 2 48 14 PM

@roiLeo roiLeo requested a review from a team as a code owner April 26, 2022 12:52
@roiLeo roiLeo requested review from kkukelka and removed request for a team April 26, 2022 12:52
@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 638602e
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62695d620006260008a993a2
😎 Deploy Preview https://deploy-preview-2905--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool 😎

@yangwao
Copy link
Member

yangwao commented Apr 27, 2022

Seems sorting by Most Reacted takes time? Maybe writing resolver to rubick?

@roiLeo
Copy link
Contributor Author

roiLeo commented Apr 27, 2022

Seems sorting by Most Reacted takes time? Maybe writing resolver to rubick?

hmm... I don't think it's needed, it loads quickly for me (like instant)

@yangwao
Copy link
Member

yangwao commented Apr 28, 2022

restarted chrome, so it's not that slow, it was like 10s, but still ain't fastest :|

Oh I see, once I click on most reacted, switch to old first, then most reacted, it's almost instant.

Probably something to do query first time, once caches it's going fast

@yangwao
Copy link
Member

yangwao commented Apr 28, 2022

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Apr 28, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 160.94 USD/KSM ~ 0.621 $KSM
🧗 HguGafrfk8nRP9a4tgJf7hLvSSFie8GtkDjyWFHQ2kDUAMc
🔗 0xbada733bb91f426c7be029bafcd238be12b5887849c91f91e80eb13e9051a38d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 28, 2022
@yangwao yangwao merged commit d9cc9c7 into kodadot:main Apr 28, 2022
@roiLeo roiLeo deleted the feature/gallery/orderByMostReacted branch April 28, 2022 09:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants