Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove copy to clipboard own address #2970

Merged
merged 3 commits into from
May 7, 2022

Conversation

petersopko
Copy link
Contributor

@petersopko petersopko commented May 7, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@petersopko petersopko requested a review from a team as a code owner May 7, 2022 11:39
@petersopko petersopko requested review from kkukelka and removed request for a team May 7, 2022 11:39
@kodabot
Copy link
Collaborator

kodabot commented May 7, 2022

SUCCESS @petersopko PR for issue #2961 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 7, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f55904d
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6276733ee68ee4000a5eab94
😎 Deploy Preview https://deploy-preview-2970--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, gonna commit my own suggestion

components/shared/format/Identity.vue Outdated Show resolved Hide resolved
@kkukelka kkukelka merged commit 643a19e into kodadot:main May 7, 2022
@kkukelka
Copy link
Member

kkukelka commented May 7, 2022

@yangwao payment bot broken?

@yangwao
Copy link
Member

yangwao commented May 7, 2022

@yangwao payment bot broken?

@petersopko did not fill up address :p
but has noted in kodadot/research#42 that bot should post if did not detect payout address or be more verbose about why the payout wasn't sent, i.e. out of balance, webhook did not hit serverless gw etc

@petersopko
Copy link
Contributor Author

pay 50

updated address

@kkukelka
Copy link
Member

kkukelka commented May 7, 2022

pay 50

@yangwao
Copy link
Member

yangwao commented May 7, 2022

🚧🚧🚧
Ah well that's what I was worried about, @KngZhi seems your regex doesn't parse this address 😛

We have meanwhile side experiment running here 👷‍♂️🧰🏗️
🚧🚧🚧

@yangwao
Copy link
Member

yangwao commented May 8, 2022

pay 50 usd

@yangwao
Copy link
Member

yangwao commented May 8, 2022

Execution timeout of 15000ms exceeded.

lol something tell me not work on Sundays

@yangwao
Copy link
Member

yangwao commented May 8, 2022

pay 50 usd

@yangwao
Copy link
Member

yangwao commented May 8, 2022

Missing address to be paid at 2970

@KngZhi yeah so did not parsed with this

target

https://beta.kodadot.xyz/transfer/?target=FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
// match KSM address, experimental
// const lookupForAddress = /kodadot.xyz\/transfer\/\?target=\w[a-zA-Z0-9]{46,}\b/g;
const lookupForAddress = /kodadot\.xyz\/transfer\?target=\w[a-zA-Z0-9]{46,}\b/g;

// const matchAddress = /\w[a-zA-Z0-9]{46,}\b/g;
const matchAddress = /\w[a-zA-Z0-9]{46,}\b/g;

@KngZhi
Copy link
Contributor

KngZhi commented May 8, 2022

oh, no~~ @yangwao

the lookupForAddress should be /kodadot\.xyz\/transfer\/?\?target=\w[a-zA-Z0-9]{46,}\b/g

please copy and replace~
don't typing, to avoid potential missing some chars.

@yangwao
Copy link
Member

yangwao commented May 8, 2022

pay 50 usd

@yangwao
Copy link
Member

yangwao commented May 8, 2022

now webhook did not arrived

pay 50 usd

@yangwao
Copy link
Member

yangwao commented May 8, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 114.77 USD/KSM ~ 0.436 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0x6aa936f7d90a846cb552d69abfc744d63bef926f1f349c020578ff5a1d14f8d5

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 8, 2022
@petersopko petersopko deleted the fix/remove-copy-to-clipboard-2961 branch September 13, 2022 09:04
@reviewpad reviewpad bot added the small Pull request is small label Apr 25, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove copy to clipboard own address while clicking on Transfer
5 participants