Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3197, 3220) - stuck chains #3252

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

petersopko
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

#3169

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@petersopko petersopko requested a review from a team as a code owner June 23, 2022 11:21
@petersopko petersopko requested review from prachi00 and removed request for a team June 23, 2022 11:21
@netlify
Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 2e5e7ef
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62b44cd3362476000918b9fe
😎 Deploy Preview https://deploy-preview-3252--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vikiival
Copy link
Member

Looks like this was caused by

cc @zhengow

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vikiival vikiival enabled auto-merge June 23, 2022 11:23
@vikiival vikiival disabled auto-merge June 23, 2022 11:23
@vikiival vikiival merged commit 63ca78a into kodadot:main Jun 23, 2022
@zhengow
Copy link
Contributor

zhengow commented Jun 23, 2022

Looks like this was caused by

cc @zhengow

I see how this bug create: dispatch method setUrlPrefix also call setApiUrl while I delete myPlugin.
Let me help to fix this bug.

@zhengow
Copy link
Contributor

zhengow commented Jun 23, 2022

Looks like this was caused by

cc @zhengow

Plz review kodadot/packages#27.
When above PR is done, I need to change some code in transfer.vue and SettingChooser.vue to fix this bug.
😶‍🌫️

@petersopko petersopko deleted the fix/3197-stuck-addresses branch September 13, 2022 09:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glitch on make offer in basilisk Sometimes I don't see collections under my account
3 participants