Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

days without accident #3427

Merged
merged 71 commits into from
Jul 12, 2022
Merged

days without accident #3427

merged 71 commits into from
Jul 12, 2022

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Jul 12, 2022

  • fix: collectionListWithSearch doesnot work
  • Limit input for user could not submit lower than minimum offer size #3278 Limit input for user could not submit lower than minimum offer size
  • [skip netlify] Update Bumped minor version of packages
  • use html validation
  • remove string
  • keep vue version
  • fix: proper styling for warning message
  • fix: handling and formatting of balance input state
  • adding chain selector
  • added wallet
  • bug report form sort browsers
  • bug issues form sorted
  • feat: calculate 14days expiration for offer
  • remove debug
  • Center table at BSX stats and handle longer item names
  • refactor: searchQuery param initialization
  • fix: search query param deletion and emit
  • fix: BSX stats currently showing burned NFTs
  • made error show up longer for users
  • Make sure if user has enough funds to make offer
  • Show available balance at gallery item at Basilisk
  • fix: missing total count of result
  • fix: unable to click submit button on bsx
  • add title for long text
  • fix: search query initialization and use bsx params
  • fix: items from collection scroll
  • refactor: use mixin property and clarify variable name
  • Update components/rmrk/Gallery/Search/SearchBarCollection.vue
  • fix: I can accept my own offer for nft Ive bought
  • Clarify reward currency in REWARD page
  • chore: hide attributeinput for now
  • adding qa-guild
  • 🐛 disabled heavy queries for profile

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • Requires deployment <rubick/magick_issue>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Jarsen and others added 30 commits July 3, 2022 18:13
fix: styling of warning message and input balance state handling
feat: calculate 14days expiration for `offer`
Jarsen136 and others added 25 commits July 10, 2022 18:01
Center table at BSX stats and handle longer item names
fix: Pagination and infinity scrolling is broken on Basilisk & Moonsama
fix: collectionListWithSearch doesnot work
fix: unable to click submit button on bsx
fix: I can accept my own offer for nft Ive bought
🐛 disabled heavy queries for profile
@yangwao yangwao requested a review from a team as a code owner July 12, 2022 15:05
@yangwao yangwao requested review from prachi00 and removed request for a team July 12, 2022 15:05
@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f77fa31
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62cd8da7d21ecb000926cd52
😎 Deploy Preview https://deploy-preview-3427--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao merged commit 1e25528 into hyper-jpeg Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants