Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 bsx collection sort & own #3441

Merged
merged 5 commits into from
Jul 15, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 15, 2022

Tested on /bsx/collection/2532142859
Thanks @petersopko for spoting this

PR type

  • Bugfix

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

@roiLeo roiLeo requested review from a team as code owners July 15, 2022 07:01
@roiLeo roiLeo requested review from kkukelka and DeluneClaire and removed request for a team July 15, 2022 07:01
@netlify
Copy link

netlify bot commented Jul 15, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit e4ab848
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62d158f555d76500097037f8
😎 Deploy Preview https://deploy-preview-3441--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo mentioned this pull request Jul 15, 2022
12 tasks
Copy link

@DeluneClaire DeluneClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@DeluneClaire DeluneClaire added bug Something isn't working 🙄 - found some 🐛 and something WFM S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Jul 15, 2022
@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 15, 2022

@DeluneClaire these changes doesn't concern the navigation bars but rather the search in the details of a collection.
I tend to explain the changes in "What's new?" paragraph.

You can test the difference between beta & this preview

(/bsx/collection/2532142859)

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DeluneClaire DeluneClaire removed the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 15, 2022
Copy link

@DeluneClaire DeluneClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@petersopko petersopko merged commit 5fed485 into kodadot:main Jul 15, 2022
@roiLeo roiLeo deleted the fix/bsx/collectionSearchOwn branch July 15, 2022 14:13
@DeluneClaire
Copy link

@DeluneClaire these changes doesn't concern the navigation bars but rather the search in the details of a collection. I tend to explain the changes in "What's new?" paragraph.

You can test the difference between beta & this preview

(/bsx/collection/2532142859)

Yes i know. I fixed it. Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search for NFTs in specific collection
4 participants