Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide extra gift event in history #3620

Closed
wants to merge 1 commit into from

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

/bsx/gallery/2425975522-7

image

@Jarsen136 Jarsen136 requested review from a team as code owners July 30, 2022 02:55
@Jarsen136 Jarsen136 requested review from prachi00 and JustLuuuu and removed request for a team July 30, 2022 02:55
@kodabot
Copy link
Collaborator

kodabot commented Jul 30, 2022

SUCCESS @Jarsen136 PR for issue #3613 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 30, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit bccde03
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62e49d8be62a5c0009ebb79e
😎 Deploy Preview https://deploy-preview-3620--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jul 30, 2022

In BSX, I found that:

  1. BUY action will transform into two events: SEND、BUY
  2. Accept Offer action will transform into three events: PAY_ROYALTY、SEND、BUY

These history events come from snek/basilisk side.

image

image

I wonder is there a better way than filtering gift events for bsx at the frontend ? WDYT @vikiival

@vikiival
Copy link
Member

Yup. It requires a bit of hacking on the kodadot/snek#44

@vikiival
Copy link
Member

Closing as this is the issue of the indexer

@vikiival vikiival closed this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is there GIFT in history if I bought and accepted offer?
3 participants