Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(searchbar): Pagination buttons on explorer is off #3809

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested review from a team as code owners August 23, 2022 11:55
@Jarsen136 Jarsen136 requested review from prachi00 and DeluneClaire and removed request for a team August 23, 2022 11:55
@kodabot
Copy link
Collaborator

kodabot commented Aug 23, 2022

WARNING @Jarsen136 PR for issue #3807 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3807

@netlify
Copy link

netlify bot commented Aug 23, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 8f3a1c4
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6304c4176184a20009661cc7
😎 Deploy Preview https://deploy-preview-3809--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2022

Code Climate has analyzed commit 031702a and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor

roiLeo commented Aug 23, 2022

#3360 is starting to be more than necessary

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

#3360 is starting to be more than necessary

something is being done in #3763 👀

@Jarsen136
Copy link
Contributor Author

#3360 is starting to be more than necessary

something is being done in #3763 👀

This bug is introduced from PR #3794

@Jarsen136
Copy link
Contributor Author

#3360 is starting to be more than necessary

Yup, it's almost done : )

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

pay 50

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 50.07 USD/KSM ~ 0.999 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xc14342c5f597757b32d533b548af36c5dad441c51fccdda6f0cb33193a82ba1c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 23, 2022
@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

let's merge if tests pass 👀

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

#3812 hmmm

@yangwao yangwao merged commit 4f78b23 into kodadot:main Aug 23, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination buttons on explorer seems bit off
4 participants