Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure spotlight name not null #4203

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Oct 28, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • show spotlight item if the name is not null

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2022-10-28 at 22 21 51

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c0c4e93
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/635bf3776d2db00008ebcfef
😎 Deploy Preview https://deploy-preview-4203--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Oct 28, 2022

Code Climate has analyzed commit c0c4e93 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian marked this pull request as ready for review October 28, 2022 15:23
@preschian preschian requested a review from a team as a code owner October 28, 2022 15:23
@preschian preschian requested review from Jarsen136 and removed request for a team October 28, 2022 15:23
@yangwao
Copy link
Member

yangwao commented Oct 28, 2022

@Jarsen136
Copy link
Contributor

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 28, 2022
@yangwao
Copy link
Member

yangwao commented Oct 28, 2022

yess

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants